Bug 119601 - Win64 missing ctiVMThrowTrampolineSlowpath
Summary: Win64 missing ctiVMThrowTrampolineSlowpath
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-08-08 15:27 PDT by Alex Christensen
Modified: 2013-08-14 14:48 PDT (History)
3 users (show)

See Also:

Patch (1.38 KB, patch)
2013-08-08 15:29 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2013-08-14 13:00 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (3.53 KB, patch)
2013-08-14 13:28 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-08-08 15:27:04 PDT
ctiVMThrowTrampolineSlowpath is not defined for the Win64 build of JavaScriptCore.  Michael's fix is based on assembly from JITStubsX86_64.h that should be in JITStubsMSVC64.asm.
Comment 1 Alex Christensen 2013-08-08 15:29:28 PDT
Created attachment 208375 [details]
Comment 2 Alex Christensen 2013-08-08 16:01:45 PDT
Comment on attachment 208375 [details]

Something is wrong with the calling convention.  Something needs to be put on the stack, and I'm not even going to pretend to know exactly how to fix it.  I'm going to leave this one to you, Michael.
Comment 3 Alex Christensen 2013-08-14 13:00:08 PDT
Created attachment 208753 [details]
Comment 4 Michael Saboff 2013-08-14 13:26:43 PDT
Comment on attachment 208753 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=208753&action=review

> Source/JavaScriptCore/jit/JITStubsMSVC64.asm:86
> +    mov rdi, r13
> +    call cti_vm_throw_slowpath
> +    ; When cti_vm_throw_slowpath returns, rax has callFrame and rdx has handler address
> +    jmp rdx

Remove this dead code.
Comment 5 Alex Christensen 2013-08-14 13:28:33 PDT
Created attachment 208754 [details]
Comment 6 WebKit Commit Bot 2013-08-14 14:48:39 PDT
Comment on attachment 208754 [details]

Clearing flags on attachment: 208754

Committed r154075: <http://trac.webkit.org/changeset/154075>
Comment 7 WebKit Commit Bot 2013-08-14 14:48:41 PDT
All reviewed patches have been landed.  Closing bug.