Bug 119587 - WKBundleFrameCopyProvisionalURL crashes when there is no provisional loader
Summary: WKBundleFrameCopyProvisionalURL crashes when there is no provisional loader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-08 11:56 PDT by Alexey Proskuryakov
Modified: 2013-08-08 12:23 PDT (History)
0 users

See Also:

Attachments
proposed fix (1.39 KB, patch)
2013-08-08 11:58 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-08-08 11:56:44 PDT 
WKBundleFrameCopyProvisionalURL crashes when there is no provisional loader.
Comment 1 Alexey Proskuryakov 2013-08-08 11:58:24 PDT 
Created attachment 208359 [details]
proposed fix
Comment 2 Darin Adler 2013-08-08 12:16:02 PDT 
Comment on attachment 208359 [details]
proposed fix

I’m going to assume that it’s better to return null rather than returning the committed string for that frame.
Comment 3 Alexey Proskuryakov 2013-08-08 12:23:21 PDT 
Committed <http://trac.webkit.org/changeset/153839>.

Yes, I think that it would be misleading to return committed URL when asked for provisional one. This also matches how -[WebFrame provisionalDataSource] works.