Bug 119585 – [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Alexey Proskuryakov]

pathSuitableForTestResult() in DumpRenderTreeChrome has some code that doesn't match other platforms.

If should return a path that's relative to main frame URL, or just the file name if the resource is not in the same directory subtree.

[Chris Dumez]

Adding Ryuan and Gyuyoung in CC since I believe they are maintaining EFL WK1.

[Gyuyoung Kim]

ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ?

[Chris Dumez]

(In reply to comment #2)
> ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ?

I really think it is up to us to fix EFL bugs.

[Gyuyoung Kim]

(In reply to comment #3)
> (In reply to comment #2)
> > ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ?
> 
> I really think it is up to us to fix EFL bugs.

Looks like that as well. Ryuan or I will fix this soon. ;)

[Alexey Proskuryakov]

Thank you! It would be much better for someone with a EFL build to do this, as there is likely to be quite a bit of test expectation cleanup.

WebKitTestRunner code can probably serve as a model here.

[Ryuan Choi]

Created attachment 208583 [details]
Patch

[Ryuan Choi]

(In reply to comment #5)
> Thank you! It would be much better for someone with a EFL build to do this, as there is likely to be quite a bit of test expectation cleanup.
> 
> WebKitTestRunner code can probably serve as a model here.

WebKitTestRunner was good reference.
I made patch similarly.

[Gyuyoung Kim]

Comment on attachment 208583 [details]
Patch

This patch lets the EFL port follow r153852. LGTM. However, ap might want to have final look before landing.

[Alexey Proskuryakov]

Comment on attachment 208583 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208583&action=review

Looks good to me too.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:226
> +const WebCore::KURL DumpRenderTreeSupportEfl::provisionalUrl(const Evas_Object* ewkFrame)

WebKit style would be "provisionalURL". I do not know if this code is intended to follow common WebKit style.

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:350
> +    KURL mainFrameUrl = KURL(ParsedURLString, ewk_frame_uri_get(browser->mainFrame()));

Ditto.

[Ryuan Choi]

Created attachment 208593 [details]
StyleFixed

[WebKit Commit Bot]

Comment on attachment 208593 [details]
StyleFixed

Clearing flags on attachment: 208593

Committed r153977: <http://trac.webkit.org/changeset/153977>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.