Bug 119558 - Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
Summary: Clean up: Simplifying the printing of the command line arguments passed to js...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-07 14:51 PDT by Daniel Bates
Modified: 2013-08-07 14:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2013-08-07 14:56 PDT, Daniel Bates 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-08-07 14:51:49 PDT 
Currently in Tools/Scripts/run-javascriptcore-tests we construct the command line to run jsDriver.pl twice: once to pretty print it standard output, and once to actually execute it. Moreover, what we print to standard output isn't equivalent to the command line we run jsDriver.pl as we exclude the prefix of /Tools/jhbuild/jhbuild-wrapper that is added for the GTK and EFL ports. We should construct the command line to execute jsDriver.pl once and then print it to standard output.
Comment 1 Daniel Bates 2013-08-07 14:56:57 PDT 
Created attachment 208300 [details]
Patch
Comment 2 Daniel Bates 2013-08-07 14:59:33 PDT 
Committed r153804: <http://trac.webkit.org/changeset/153804>