Bug 119543 - Create WebCore/style and move StyleResolveTree there
Summary: Create WebCore/style and move StyleResolveTree there
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-07 05:32 PDT by Antti Koivisto
Modified: 2013-08-07 07:22 PDT (History)
12 users (show)

See Also:

Attachments
patch (41.88 KB, patch)
2013-08-07 05:36 PDT, Antti Koivisto 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
another (42.32 KB, patch)
2013-08-07 05:53 PDT, Antti Koivisto 		kling: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-07 05:32:13 PDT 
WebCore/css is bloated. We should move the internal style representation and the style resolver related code to a directory of their own. CSS language related code including parser and CSSOM stays under css.

Things named StyleFoo should generally move under WebCore/style. They should also be moved to the Style namespace at the same time.
Comment 1 Antti Koivisto 2013-08-07 05:36:01 PDT 
Created attachment 208255 [details]
patch
Comment 2 WebKit Commit Bot 2013-08-07 05:38:59 PDT 
Attachment 208255 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCoreCommon.props', u'Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/StyleResolveTree.cpp', u'Source/WebCore/css/StyleResolveTree.h', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/style/StyleResolveTree.h']" exit_code: 1
Source/WebCore/CMakeLists.txt:2329:  No trailing spaces  [whitespace/trailing] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-08-07 05:44:57 PDT 
Comment on attachment 208255 [details]
patch

Attachment 208255 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1375204
Comment 4 Early Warning System Bot 2013-08-07 05:46:07 PDT 
Comment on attachment 208255 [details]
patch

Attachment 208255 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1376257
Comment 5 Antti Koivisto 2013-08-07 05:53:33 PDT 
Created attachment 208259 [details]
another
Comment 6 Andreas Kling 2013-08-07 06:01:49 PDT 
Comment on attachment 208259 [details]
another

r=me. Have a nice time with the bots!
Comment 7 EFL EWS Bot 2013-08-07 07:21:02 PDT 
Comment on attachment 208259 [details]
another

Attachment 208259 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1378234
Comment 8 Antti Koivisto 2013-08-07 07:22:00 PDT 
http://trac.webkit.org/changeset/153785