RESOLVED FIXED Bug 119543
Create WebCore/style and move StyleResolveTree there 
https://bugs.webkit.org/show_bug.cgi?id=119543
Summary Create WebCore/style and move StyleResolveTree there
Antti Koivisto
Reported 2013-08-07 05:32:13 PDT
WebCore/css is bloated. We should move the internal style representation and the style resolver related code to a directory of their own. CSS language related code including parser and CSSOM stays under css. Things named StyleFoo should generally move under WebCore/style. They should also be moved to the Style namespace at the same time.
Attachments
patch (41.88 KB, patch)
2013-08-07 05:36 PDT, Antti Koivisto 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
another (42.32 KB, patch)
2013-08-07 05:53 PDT, Antti Koivisto 		kling: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-07 05:36:01 PDT
Created attachment 208255 [details] patch
WebKit Commit Bot
Comment 2 2013-08-07 05:38:59 PDT
Attachment 208255 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.am', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCoreCommon.props', u'Source/WebCore/WebCore.vcxproj/copyForwardingHeaders.cmd', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/StyleResolveTree.cpp', u'Source/WebCore/css/StyleResolveTree.h', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/style/StyleResolveTree.h']" exit_code: 1 Source/WebCore/CMakeLists.txt:2329: No trailing spaces [whitespace/trailing] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 3 2013-08-07 05:44:57 PDT
Comment on attachment 208255 [details] patch Attachment 208255 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1375204
Early Warning System Bot
Comment 4 2013-08-07 05:46:07 PDT
Comment on attachment 208255 [details] patch Attachment 208255 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1376257
Antti Koivisto
Comment 5 2013-08-07 05:53:33 PDT
Created attachment 208259 [details] another
Andreas Kling
Comment 6 2013-08-07 06:01:49 PDT
Comment on attachment 208259 [details] another r=me. Have a nice time with the bots!
EFL EWS Bot
Comment 7 2013-08-07 07:21:02 PDT
Comment on attachment 208259 [details] another Attachment 208259 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1378234
Antti Koivisto
Comment 8 2013-08-07 07:22:00 PDT
http://trac.webkit.org/changeset/153785
Note You need to log in before you can comment on or make changes to this bug.