Bug 119535 - Fall out of simple image layer optimization if the image has EXIF rotation
Summary: Fall out of simple image layer optimization if the image has EXIF rotation
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2013-08-06 19:09 PDT by Tim Horton
Modified: 2013-08-11 22:15 PDT (History)
7 users (show)

See Also:

patch (8.71 KB, patch)
2013-08-06 19:21 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
patch (60.09 KB, patch)
2013-08-06 19:33 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-06 19:09:06 PDT
We need to transform the image when painting it, so we need to fall out of the optimization. We could do some complicated things to keep the optimization in this case, but it's not a super critical case and the simple image layer optimization is relatively new.

Comment 1 Tim Horton 2013-08-06 19:09:57 PDT
Conveniently the layer is already the right size/shape, so we really just need to tell RenderLayerBacking to do the right thing.
Comment 2 Tim Horton 2013-08-06 19:21:04 PDT
Created attachment 208231 [details]
Comment 3 Tim Horton 2013-08-06 19:33:56 PDT
Created attachment 208233 [details]
Comment 4 Tim Horton 2013-08-07 12:52:00 PDT
Comment 5 Benjamin Poulain 2013-08-11 22:04:10 PDT
Wouldn't a ref-test be nicer here?
Comment 6 Tim Horton 2013-08-11 22:15:39 PDT
(In reply to comment #5)
> Wouldn't a ref-test be nicer here?

Yes; I just borrowed the existing image-orientation test and made it composited, though.