Bug 119533 - Hashing SecurityOrigin's can lead to trouble if you mutate them :(
Summary: Hashing SecurityOrigin's can lead to trouble if you mutate them :(
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
: 99266 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-06 17:55 PDT by Sam Weinig
Modified: 2013-08-08 15:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2013-08-06 18:06 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (2.82 KB, patch)
2013-08-06 19:24 PDT, Sam Weinig 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-08-06 17:55:01 PDT 
Hashing SecurityOrigin's can lead to trouble if you mutate them :(
Comment 1 Sam Weinig 2013-08-06 18:06:18 PDT 
Created attachment 208230 [details]
Patch
Comment 2 Build Bot 2013-08-06 18:34:28 PDT 
Comment on attachment 208230 [details]
Patch

Attachment 208230 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1418039
Comment 3 Build Bot 2013-08-06 18:49:44 PDT 
Comment on attachment 208230 [details]
Patch

Attachment 208230 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1417041
Comment 4 Sam Weinig 2013-08-06 19:24:47 PDT 
Created attachment 208232 [details]
Patch
Comment 5 Andreas Kling 2013-08-07 06:05:43 PDT 
Comment on attachment 208232 [details]
Patch

r=me

Very related: bug 99266.
Comment 6 Alexey Proskuryakov 2013-08-07 11:40:32 PDT 
Could you please also address comments around equal() in SecurityOrigin.h, and add a Radar link?
Comment 7 Sam Weinig 2013-08-08 14:59:58 PDT 
Committed r153850: <http://trac.webkit.org/changeset/153850>
Comment 8 Sam Weinig 2013-08-08 15:00:39 PDT 
*** Bug 99266 has been marked as a duplicate of this bug. ***