Bug 119528 – DFG FixupPhase should insert Int32ToDouble nodes for number uses in NewArray, and SpeculativeJIT 64-bit should not try to coerce integer constants to double constants

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Filip Pizlo]

DFG FixupPhase should insert Int32ToDouble nodes for number uses in NewArray, and SpeculativeJIT 64-bit should not try to coerce integer constants to double constants

[Filip Pizlo]

Created attachment 208219 [details]
Patch

[Filip Pizlo]

<rdar://problem/14655517>

[Geoffrey Garen]

Comment on attachment 208219 [details]
Patch

r=me

[Mark Hahnenberg]

Comment on attachment 208219 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208219&action=review

> Source/JavaScriptCore/dfg/DFGDriver.cpp:-75
> -

Revert!

[Mark Hahnenberg]

(In reply to comment #4)
> (From update of attachment 208219 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208219&action=review
> 
> > Source/JavaScriptCore/dfg/DFGDriver.cpp:-75
> > -
> 
> Revert!

Unless it was intentional, of course.

[Filip Pizlo]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 208219 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=208219&action=review
> > 
> > > Source/JavaScriptCore/dfg/DFGDriver.cpp:-75
> > > -
> > 
> > Revert!
> 
> Unless it was intentional, of course.

Yeah, it was intentional :-)  It seems that we got extra whitespace in there from past bisecting hacks.

[EFL EWS Bot]

Comment on attachment 208219 [details]
Patch

Attachment 208219 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1414050

[Build Bot]

Comment on attachment 208219 [details]
Patch

Attachment 208219 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1418001

New failing tests:
fast/dom/Window/anonymous-slot-with-changes.html
fast/dom/Window/window-postmessage-clone.html

[Build Bot]

Created attachment 208223 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 208219 [details]
Patch

Attachment 208219 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1370578

New failing tests:
fast/dom/Window/anonymous-slot-with-changes.html

[Build Bot]

Created attachment 208227 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Filip Pizlo]

(In reply to comment #11)
> Created an attachment (id=208227) [details]
> Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

This is a real failure: tryGetIndexQuickly is asserting too strongly.  It should assert that in the case of an INT32 array, the result is either JSValue() or int32; but it's asserting that it's an int32.

[Filip Pizlo]

(In reply to comment #12)
> (In reply to comment #11)
> > Created an attachment (id=208227) [details] [details]
> > Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
> > 
> > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
> > Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
> 
> This is a real failure: tryGetIndexQuickly is asserting too strongly.  It should assert that in the case of an INT32 array, the result is either JSValue() or int32; but it's asserting that it's an int32.

Yup.  Fixing that assertion also makes everything pass.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/153778