Bug 119527 - Web Inspector: Remove stale code in ResourceContentView
Summary: Web Inspector: Remove stale code in ResourceContentView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-06 13:44 PDT by Joseph Pecoraro
Modified: 2013-08-06 14:37 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.49 KB, patch)
2013-08-06 13:46 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-06 13:44:51 PDT 
The ResourceContentView type changing handling was moved to ResourceClusterContentView a while ago. In the process some code was leftover in ResourceContentView which can be removed:

    this._resource.removeEventListener(WebInspector.Resource.Event.TypeDidChange, this._resourceTypeDidChange, this);

ResourceContentView no longer adds that event listener to the resource, and doesn't have a this._resourceTypeDidChange function, so it is likely passing null and not removing anything.
Comment 1 Radar WebKit Bug Importer 2013-08-06 13:45:21 PDT 
<rdar://problem/14664197>
Comment 2 Joseph Pecoraro 2013-08-06 13:46:44 PDT 
Created attachment 208215 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2013-08-06 14:37:17 PDT 
Comment on attachment 208215 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 208215

Committed r153765: <http://trac.webkit.org/changeset/153765>
Comment 4 WebKit Commit Bot 2013-08-06 14:37:19 PDT 
All reviewed patches have been landed.  Closing bug.