WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 119527
Web Inspector: Remove stale code in ResourceContentView
https://bugs.webkit.org/show_bug.cgi?id=119527
Summary
Web Inspector: Remove stale code in ResourceContentView
Joseph Pecoraro
Reported
2013-08-06 13:44:51 PDT
The ResourceContentView type changing handling was moved to ResourceClusterContentView a while ago. In the process some code was leftover in ResourceContentView which can be removed: this._resource.removeEventListener(WebInspector.Resource.Event.TypeDidChange, this._resourceTypeDidChange, this); ResourceContentView no longer adds that event listener to the resource, and doesn't have a this._resourceTypeDidChange function, so it is likely passing null and not removing anything.
Attachments
[PATCH] Proposed Fix
(1.49 KB, patch)
2013-08-06 13:46 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-08-06 13:45:21 PDT
<
rdar://problem/14664197
>
Joseph Pecoraro
Comment 2
2013-08-06 13:46:44 PDT
Created
attachment 208215
[details]
[PATCH] Proposed Fix
WebKit Commit Bot
Comment 3
2013-08-06 14:37:17 PDT
Comment on
attachment 208215
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 208215 Committed
r153765
: <
http://trac.webkit.org/changeset/153765
>
WebKit Commit Bot
Comment 4
2013-08-06 14:37:19 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug