Bug 119510 – Update scheme list according to latest specification

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

New schemes are added to it additionally. Those are im, ircs and webtai. As additional work, scheme order is listed to be sync with spec.

Spec: http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155491

[EFL EWS Bot]

Created attachment 208165 [details]
Patch

[Gyuyoung Kim]

Created attachment 208166 [details]
Patch

[Gyuyoung Kim]

Created attachment 208167 [details]
Patch

[Gyuyoung Kim]

Created attachment 208168 [details]
Patch

[Gyuyoung Kim]

CC'ing Kling. Could you take a look this patch ?

[Build Bot]

Comment on attachment 208168 [details]
Patch

Attachment 208168 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1431080

New failing tests:
fast/dom/unregister-protocol-handler.html

[Build Bot]

Created attachment 208317 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Build Bot]

Comment on attachment 208168 [details]
Patch

Attachment 208168 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1430079

New failing tests:
fast/dom/unregister-protocol-handler.html

[Build Bot]

Created attachment 208318 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Gyuyoung Kim]

Created attachment 208332 [details]
Patch

[Chris Dumez]

Comment on attachment 208332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208332&action=review

> Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:65
> +        "webtai",

http://www.whatwg.org/specs/web-apps/current-work/#whitelisted-scheme says "wtai" not "webtai"

[Gyuyoung Kim]

Created attachment 208581 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #11)
> (From update of attachment 208332 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208332&action=review
> 
> > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:65
> > +        "webtai",
> 
> http://www.whatwg.org/specs/web-apps/current-work/#whitelisted-scheme says "wtai" not "webtai"

Nice catch! it looks spec is being changed. Patch is updated according to latest spec.

[Chris Dumez]

Comment on attachment 208581 [details]
Patch

Looks fine. r=me.

[WebKit Commit Bot]

Comment on attachment 208581 [details]
Patch

Clearing flags on attachment: 208581

Committed r153986: <http://trac.webkit.org/changeset/153986>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.