Bug 119510 - Update scheme list according to latest specification
Summary: Update scheme list according to latest specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-08-05 21:14 PDT by Gyuyoung Kim
Modified: 2013-08-13 00:10 PDT (History)
9 users (show)

See Also:

Attachments
Patch (10.64 KB, patch)
2013-08-05 22:53 PDT, EFL EWS Bot 		no flags Details | Formatted Diff | Diff
Patch (10.64 KB, patch)
2013-08-05 22:55 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (10.64 KB, patch)
2013-08-05 23:10 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (10.62 KB, patch)
2013-08-05 23:18 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (543.73 KB, application/zip)
2013-08-08 00:43 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (492.34 KB, application/zip)
2013-08-08 01:14 PDT, Build Bot 		no flags Details
Patch (10.57 KB, patch)
2013-08-08 05:56 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (10.48 KB, patch)
2013-08-12 18:29 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-08-05 21:14:08 PDT 
New schemes are added to it additionally. Those are im, ircs and webtai. As additional work, scheme order is listed to be sync with spec.

Spec: http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155491
Comment 1 EFL EWS Bot 2013-08-05 22:53:28 PDT 
Created attachment 208165 [details]
Patch
Comment 2 Gyuyoung Kim 2013-08-05 22:55:53 PDT 
Created attachment 208166 [details]
Patch
Comment 3 Gyuyoung Kim 2013-08-05 23:10:09 PDT 
Created attachment 208167 [details]
Patch
Comment 4 Gyuyoung Kim 2013-08-05 23:18:29 PDT 
Created attachment 208168 [details]
Patch
Comment 5 Gyuyoung Kim 2013-08-07 23:10:46 PDT 
CC'ing Kling. Could you take a look this patch ?
Comment 6 Build Bot 2013-08-08 00:43:24 PDT 
Comment on attachment 208168 [details]
Patch

Attachment 208168 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1431080

New failing tests:
fast/dom/unregister-protocol-handler.html
Comment 7 Build Bot 2013-08-08 00:43:28 PDT 
Created attachment 208317 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 8 Build Bot 2013-08-08 01:14:27 PDT 
Comment on attachment 208168 [details]
Patch

Attachment 208168 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1430079

New failing tests:
fast/dom/unregister-protocol-handler.html
Comment 9 Build Bot 2013-08-08 01:14:32 PDT 
Created attachment 208318 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 10 Gyuyoung Kim 2013-08-08 05:56:09 PDT 
Created attachment 208332 [details]
Patch
Comment 11 Chris Dumez 2013-08-12 10:51:38 PDT 
Comment on attachment 208332 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208332&action=review

> Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:65
> +        "webtai",

http://www.whatwg.org/specs/web-apps/current-work/#whitelisted-scheme says "wtai" not "webtai"
Comment 12 Gyuyoung Kim 2013-08-12 18:29:57 PDT 
Created attachment 208581 [details]
Patch
Comment 13 Gyuyoung Kim 2013-08-12 18:30:48 PDT 
(In reply to comment #11)
> (From update of attachment 208332 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208332&action=review
> 
> > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:65
> > +        "webtai",
> 
> http://www.whatwg.org/specs/web-apps/current-work/#whitelisted-scheme says "wtai" not "webtai"

Nice catch! it looks spec is being changed. Patch is updated according to latest spec.
Comment 14 Chris Dumez 2013-08-12 22:48:26 PDT 
Comment on attachment 208581 [details]
Patch

Looks fine. r=me.
Comment 15 WebKit Commit Bot 2013-08-13 00:10:28 PDT 
Comment on attachment 208581 [details]
Patch

Clearing flags on attachment: 208581

Committed r153986: <http://trac.webkit.org/changeset/153986>
Comment 16 WebKit Commit Bot 2013-08-13 00:10:35 PDT 
All reviewed patches have been landed.  Closing bug.