Bug 119506 - FastMalloc should support MallocStackLogging
Summary: FastMalloc should support MallocStackLogging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-05 18:31 PDT by Mark Rowe (bdash)
Modified: 2013-08-06 15:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (7.07 KB, patch)
2013-08-05 18:47 PDT, Mark Rowe (bdash) 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2013-08-05 18:31:35 PDT 
As it says in the title.

<rdar://problem/5927399>
Comment 1 Mark Rowe (bdash) 2013-08-05 18:47:30 PDT 
Created attachment 208163 [details]
Patch v1

This is a less than 1% regression on a malloc benchmark that Geoff showed me when stack logging is not enabled.
Comment 2 WebKit Commit Bot 2013-08-05 18:48:31 PDT 
Attachment 208163 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/FastMalloc.cpp']" exit_code: 1
Source/WTF/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2013-08-06 14:14:43 PDT 
Comment on attachment 208163 [details]
Patch v1

r=me

Please add bugzilla bug # to ChangeLog.
Comment 4 Mark Rowe (bdash) 2013-08-06 15:09:10 PDT 
Landed in r153767.