Bug 119505 - Delay Arguments creation in strict mode
Summary: Delay Arguments creation in strict mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-05 18:05 PDT by Oliver Hunt
Modified: 2013-08-20 16:40 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.71 KB, patch)
2013-08-05 18:10 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (12.61 KB, patch)
2013-08-06 12:04 PDT, Oliver Hunt 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-08-05 18:05:39 PDT 
Delay Arguments creation in strict mode
Comment 1 Oliver Hunt 2013-08-05 18:10:53 PDT 
Created attachment 208162 [details]
Patch
Comment 2 Geoffrey Garen 2013-08-05 18:15:51 PDT 
Comment on attachment 208162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208162&action=review

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1749
> -    if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !m_codeBlock->isStrictMode()) {
> +    if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !isStrictMode()) {

Doesn't this need to be !shouldTearOffArgumentsEagerly()?
Comment 3 Oliver Hunt 2013-08-05 18:17:02 PDT 
(In reply to comment #2)
> (From update of attachment 208162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208162&action=review
> 
> > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1749
> > -    if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !m_codeBlock->isStrictMode()) {
> > +    if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !isStrictMode()) {
> 
> Doesn't this need to be !shouldTearOffArgumentsEagerly()?

Nope, we perform the Arguments object tear off during arguments object creation when we're in strict mode.
Comment 4 EFL EWS Bot 2013-08-05 18:55:34 PDT 
Comment on attachment 208162 [details]
Patch

Attachment 208162 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1350033
Comment 5 Oliver Hunt 2013-08-06 12:04:30 PDT 
Created attachment 208209 [details]
Patch
Comment 6 Geoffrey Garen 2013-08-06 14:10:29 PDT 
Comment on attachment 208209 [details]
Patch

r=me
Comment 7 Oliver Hunt 2013-08-06 14:19:02 PDT 
Committed r153763: <http://trac.webkit.org/changeset/153763>
Comment 8 Geoffrey Garen 2013-08-20 16:40:43 PDT 
<rdar://problem/14790809>