Bug 119502 - WebGL should be enabled on WinCairo port
Summary: WebGL should be enabled on WinCairo port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-05 17:05 PDT by Alex Christensen
Modified: 2013-08-06 15:11 PDT (History)
4 users (show)

See Also:


Attachments
Patch (11.69 KB, patch)
2013-08-05 17:10 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (11.84 KB, patch)
2013-08-06 11:07 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-08-05 17:05:35 PDT
The WinCairo port is ready for WebGL to be enabled, and nobody from webkit-dev objected.  This involves #defines in FeatureDefines.h, building ANGLE, and linking to ANGLE.  As a temporary solution I'm going to put the additional libraries to link to in WebKitCFLite.props.  They'll eventually be moved to WebKitCommon.props.
Comment 1 Alex Christensen 2013-08-05 17:10:49 PDT
Created attachment 208158 [details]
Patch
Comment 2 Benjamin Poulain 2013-08-05 23:56:23 PDT
Comment on attachment 208158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208158&action=review

> Source/WTF/wtf/FeatureDefines.h:266
> +#if !defined(WTF_USE_3D_GRAPHICS)
> +#define WTF_USE_3D_GRAPHICS 1
> +#endif
> +
> +#if !defined(WTF_USE_OPENGL)
> +#define WTF_USE_OPENGL 1
> +#endif
> +
> +#if !defined(WTF_USE_OPENGL_ES_2)
> +#define WTF_USE_OPENGL_ES_2 1
> +#endif
> +
> +#if !defined(WTF_USE_EGL)
> +#define WTF_USE_EGL 1
> +#endif
> +
> +#if !defined(WTF_USE_SURFACE)
> +#define WTF_USE_SURFACE 1
> +#endif

The USE() macros are not defined in this file.
Comment 3 Alex Christensen 2013-08-06 11:07:52 PDT
Created attachment 208205 [details]
Patch
Comment 4 Brent Fulgham 2013-08-06 14:51:02 PDT
Comment on attachment 208205 [details]
Patch

Looks good to me, too.
Comment 5 WebKit Commit Bot 2013-08-06 15:11:55 PDT
Comment on attachment 208205 [details]
Patch

Clearing flags on attachment: 208205

Committed r153768: <http://trac.webkit.org/changeset/153768>
Comment 6 WebKit Commit Bot 2013-08-06 15:11:57 PDT
All reviewed patches have been landed.  Closing bug.