Bug 119502 – WebGL should be enabled on WinCairo port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Alex Christensen]

The WinCairo port is ready for WebGL to be enabled, and nobody from webkit-dev objected.  This involves #defines in FeatureDefines.h, building ANGLE, and linking to ANGLE.  As a temporary solution I'm going to put the additional libraries to link to in WebKitCFLite.props.  They'll eventually be moved to WebKitCommon.props.

[Alex Christensen]

Created attachment 208158 [details]
Patch

[Benjamin Poulain]

Comment on attachment 208158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208158&action=review

> Source/WTF/wtf/FeatureDefines.h:266
> +#if !defined(WTF_USE_3D_GRAPHICS)
> +#define WTF_USE_3D_GRAPHICS 1
> +#endif
> +
> +#if !defined(WTF_USE_OPENGL)
> +#define WTF_USE_OPENGL 1
> +#endif
> +
> +#if !defined(WTF_USE_OPENGL_ES_2)
> +#define WTF_USE_OPENGL_ES_2 1
> +#endif
> +
> +#if !defined(WTF_USE_EGL)
> +#define WTF_USE_EGL 1
> +#endif
> +
> +#if !defined(WTF_USE_SURFACE)
> +#define WTF_USE_SURFACE 1
> +#endif

The USE() macros are not defined in this file.

[Alex Christensen]

Created attachment 208205 [details]
Patch

[Brent Fulgham]

Comment on attachment 208205 [details]
Patch

Looks good to me, too.

[WebKit Commit Bot]

Comment on attachment 208205 [details]
Patch

Clearing flags on attachment: 208205

Committed r153768: <http://trac.webkit.org/changeset/153768>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.