Bug 119501 - Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers
Summary: Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-05 16:51 PDT by Ryosuke Niwa
Modified: 2013-08-05 19:00 PDT (History)
4 users (show)

See Also:


Attachments
Fixes the bug (3.11 KB, patch)
2013-08-05 17:45 PDT, Ryosuke Niwa
enrica: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-08-05 16:51:57 PDT
setMarkedText is lower on ToT.

To mitigate this, avoid computing the start and the end of words in Editor::updateMarkersForWordsAffectedByEditing(bool) when there are no document markers.

<rdar://problem/14439234>
Comment 1 Ryosuke Niwa 2013-08-05 17:45:56 PDT
Created attachment 208161 [details]
Fixes the bug
Comment 2 Enrica Casucci 2013-08-05 18:59:52 PDT
Comment on attachment 208161 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=208161&action=review

Yes!

> Source/WebCore/ChangeLog:3
> +        Editor::updateMarkersForWordsAffectedByEditing(bool) shouldn't compute start and end of words when there are nor markers

typo: 'not'
Comment 3 Ryosuke Niwa 2013-08-05 19:00:45 PDT
Committed r153734: <http://trac.webkit.org/changeset/153734>