Bug 119496 – REGRESSION (r153060?): Microphone appears in the way of text when dictating an e-mail

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Alexey Proskuryakov]

Steps to reproduce:
1. In Blot, or another WebKit1 application, type a line of text, then press Enter.
2. With insertion point at the beginning of line,invoke dictation.

Results: dictation popover covers the text you have.

<rdar://problem/14637103>

[Alexey Proskuryakov]

Created attachment 208150 [details]
proposed fix

[Ryosuke Niwa]

Comment on attachment 208150 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=208150&action=review

Seems sensible.

> Source/WebCore/ChangeLog:3
> +        <rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way

You should put <rdar://problem/14637103> on a separate line below the bugzilla URL.

[Alexey Proskuryakov]

So what happened was that the rect remained null as originally set:

    FloatRect result;
    for (size_t i = 0; i < quads.size(); ++i)
        result.unite(quads[i].boundingBox());

The unite() call does nothing when appending an empty rect, but we want to return the empty caret rect, not the initial null one!

We also don't want the initial null rect as part of the result, which would happen if I simply changed unite() to uniteEvenIfEmpty().

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r153725>.