Bug 119496 - REGRESSION (r153060?): Microphone appears in the way of text when dictating an e-mail
Summary: REGRESSION (r153060?): Microphone appears in the way of text when dictating a...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Keywords: InRadar, Regression
Depends on:
Reported: 2013-08-05 14:33 PDT by Alexey Proskuryakov
Modified: 2013-08-05 14:55 PDT (History)
4 users (show)

See Also:

proposed fix (5.84 KB, patch)
2013-08-05 14:45 PDT, Alexey Proskuryakov
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-08-05 14:33:13 PDT
Steps to reproduce:
1. In Blot, or another WebKit1 application, type a line of text, then press Enter.
2. With insertion point at the beginning of line,invoke dictation.

Results: dictation popover covers the text you have.

Comment 1 Alexey Proskuryakov 2013-08-05 14:45:00 PDT
Created attachment 208150 [details]
proposed fix
Comment 2 Ryosuke Niwa 2013-08-05 14:47:33 PDT
Comment on attachment 208150 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=208150&action=review

Seems sensible.

> Source/WebCore/ChangeLog:3
> +        <rdar://problem/14637103> REGRESSION (r153060?): Microphone appears in the way

You should put <rdar://problem/14637103> on a separate line below the bugzilla URL.
Comment 3 Alexey Proskuryakov 2013-08-05 14:53:31 PDT
So what happened was that the rect remained null as originally set:

    FloatRect result;
    for (size_t i = 0; i < quads.size(); ++i)

The unite() call does nothing when appending an empty rect, but we want to return the empty caret rect, not the initial null one!

We also don't want the initial null rect as part of the result, which would happen if I simply changed unite() to uniteEvenIfEmpty().
Comment 4 Alexey Proskuryakov 2013-08-05 14:55:10 PDT
Committed <http://trac.webkit.org/r153725>.