Bug 119491 - [CSS Shapes] New positioning model: scripted shape-margin tests
Summary: [CSS Shapes] New positioning model: scripted shape-margin tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks: 117898
  Show dependency tree / graph
 
Reported: 2013-08-05 11:59 PDT by Bem Jones-Bey
Modified: 2013-08-06 15:15 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.26 KB, patch)
2013-08-06 08:40 PDT, Hans Muller 		achicu: review+
Details | Formatted Diff | Diff
Patch (7.36 KB, patch)
2013-08-06 13:57 PDT, Hans Muller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-08-05 11:59:51 PDT 
Update the shape-margin script tests to work with the new positioning model.

They are the following tests:
shape-outside-floats-diamond-margin-polygon.html
shape-outside-floats-ellipse-margin-bottom.html (strictly speaking not a script test, but including it here anyways)
shape-outside-floats-ellipse-margin-left.html
shape-outside-floats-ellipse-margin-right.html
Comment 1 Hans Muller 2013-08-06 08:40:21 PDT 
Created attachment 208193 [details]
Patch

Update some of the shape-margin tests to work with the new positioning model. Floats that specify shape-outside are now positioned according to their margin box, not the bounding box of the shape-outside shape. The tests have been revised to reflect the change.
Comment 2 Alexandru Chiculita 2013-08-06 11:23:11 PDT 
Comment on attachment 208193 [details]
Patch

r=me
Comment 3 Hans Muller 2013-08-06 13:57:23 PDT 
Created attachment 208217 [details]
Patch
Comment 4 WebKit Commit Bot 2013-08-06 15:15:08 PDT 
Comment on attachment 208217 [details]
Patch

Clearing flags on attachment: 208217

Committed r153769: <http://trac.webkit.org/changeset/153769>
Comment 5 WebKit Commit Bot 2013-08-06 15:15:10 PDT 
All reviewed patches have been landed.  Closing bug.