Bug 119489 - Move TypedArray implementation into JSC
Summary: Move TypedArray implementation into JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks: 119064
  Show dependency tree / graph
 
Reported: 2013-08-05 10:28 PDT by Oliver Hunt
Modified: 2013-09-03 02:29 PDT (History)
5 users (show)

See Also:

Attachments
Patch (255.81 KB, patch)
2013-08-05 10:30 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (270.49 KB, patch)
2013-08-05 12:20 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (265.36 KB, patch)
2013-08-05 12:47 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (267.16 KB, patch)
2013-08-05 13:13 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (280.04 KB, patch)
2013-08-05 13:23 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (266.79 KB, patch)
2013-08-05 14:31 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (281.74 KB, patch)
2013-08-05 14:48 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-08-05 10:28:32 PDT 
Move TypedArray implementation into JSC
Comment 1 Oliver Hunt 2013-08-05 10:30:18 PDT 
Created attachment 208135 [details]
Patch
Comment 2 Early Warning System Bot 2013-08-05 10:43:16 PDT 
Comment on attachment 208135 [details]
Patch

Attachment 208135 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1386130
Comment 3 Early Warning System Bot 2013-08-05 10:47:38 PDT 
Comment on attachment 208135 [details]
Patch

Attachment 208135 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1374176
Comment 4 EFL EWS Bot 2013-08-05 11:14:39 PDT 
Comment on attachment 208135 [details]
Patch

Attachment 208135 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1375168
Comment 5 EFL EWS Bot 2013-08-05 11:59:08 PDT 
Comment on attachment 208135 [details]
Patch

Attachment 208135 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1383190
Comment 6 Oliver Hunt 2013-08-05 12:20:19 PDT 
Created attachment 208138 [details]
Patch
Comment 7 Filip Pizlo 2013-08-05 12:27:27 PDT 
Comment on attachment 208138 [details]
Patch

Thanks bro!
Comment 8 Oliver Hunt 2013-08-05 12:29:49 PDT 
waiting for so many builds :-(
Comment 9 Early Warning System Bot 2013-08-05 12:32:12 PDT 
Comment on attachment 208138 [details]
Patch

Attachment 208138 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1362038
Comment 10 Early Warning System Bot 2013-08-05 12:33:47 PDT 
Comment on attachment 208138 [details]
Patch

Attachment 208138 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1343033
Comment 11 EFL EWS Bot 2013-08-05 12:35:11 PDT 
Comment on attachment 208138 [details]
Patch

Attachment 208138 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1328039
Comment 12 Oliver Hunt 2013-08-05 12:47:24 PDT 
Created attachment 208141 [details]
Patch
Comment 13 Early Warning System Bot 2013-08-05 13:04:50 PDT 
Comment on attachment 208141 [details]
Patch

Attachment 208141 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1363042
Comment 14 Early Warning System Bot 2013-08-05 13:08:07 PDT 
Comment on attachment 208141 [details]
Patch

Attachment 208141 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1364051
Comment 15 EFL EWS Bot 2013-08-05 13:10:32 PDT 
Comment on attachment 208141 [details]
Patch

Attachment 208141 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1327053
Comment 16 Oliver Hunt 2013-08-05 13:13:01 PDT 
Created attachment 208142 [details]
Patch
Comment 17 Oliver Hunt 2013-08-05 13:23:07 PDT 
Created attachment 208144 [details]
Patch
Comment 18 Oliver Hunt 2013-08-05 13:26:47 PDT 
sigh, lost project file changes going from one machine to the other, let's try this again
Comment 19 EFL EWS Bot 2013-08-05 14:27:32 PDT 
Comment on attachment 208144 [details]
Patch

Attachment 208144 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1366074
Comment 20 Oliver Hunt 2013-08-05 14:31:23 PDT 
Created attachment 208148 [details]
Patch
Comment 21 Early Warning System Bot 2013-08-05 14:47:55 PDT 
Comment on attachment 208148 [details]
Patch

Attachment 208148 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1346072
Comment 22 Oliver Hunt 2013-08-05 14:48:51 PDT 
Created attachment 208151 [details]
Patch
Comment 23 Oliver Hunt 2013-08-05 15:10:45 PDT 
Committed r153728: <http://trac.webkit.org/changeset/153728>
Comment 24 Peng Xinchao 2013-08-14 22:59:45 PDT 
    (In reply to comment #0)
> Move TypedArray implementation into JSC

I have a quession :
   Why do you do this? What is its advantage ?
Comment 25 Chris Dumez 2013-08-14 23:29:18 PDT 
(In reply to comment #24)
>     (In reply to comment #0)
> > Move TypedArray implementation into JSC
> 
> I have a quession :
>    Why do you do this? What is its advantage ?

It was explained on the mailing list. Please check:
[webkit-dev] Heads up: large typed array rewrite
Comment 26 Peng Xinchao 2013-09-03 02:29:17 PDT 
GNUmake build failed :
log info :
    ./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSInternals.o: In function `_ZN7WebCore43jsInternalsPrototypeFunctionSerializeObjectEPN3JSC9ExecStateE':
JSInternals.cpp:(.text+0x7f78): undefined reference to `_ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueEPN3WTF6VectorINS5_6RefPtrINS_11MessagePortEEELj1ENS5_15CrashOnOverflowEEEPNS6_INS7_INS1_11ArrayBufferEEELj1ESA_EENS_22SerializationErrorModeE'
JSInternals.cpp:(.text+0x8028): undefined reference to `_ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS0_11ArrayBufferE'
collect2: error: ld returned 1 exit status