WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 119360
119464
Add srcset support to HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=119464
Summary
Add srcset support to HTMLPreloadScanner
Yoav Weiss
Reported
2013-08-02 23:52:15 PDT
Add srcset support to HTMLPreloadScanner
Attachments
Patch
(18.40 KB, patch)
2013-08-03 00:14 PDT
,
Yoav Weiss
dino
: review-
Details
Formatted Diff
Diff
Patch
(18.48 KB, patch)
2013-08-03 04:02 PDT
,
Yoav Weiss
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Yoav Weiss
Comment 1
2013-08-03 00:14:56 PDT
Created
attachment 208058
[details]
Patch
Yoav Weiss
Comment 2
2013-08-03 00:19:57 PDT
The recently landed srcset support (
https://bugs.webkit.org/show_bug.cgi?id=110252
) lack a HTMlPreloadScanner support. That means that for pages with a script tag at the page's top, images with both "src" and "srcset" attributes will have 2 resources downloaded when only one is needed. (Because the "src" resource is downloaded by the preload scanner). This patch fixes that by adding srcset support to HTMLPreloadScanner.
Joseph Pecoraro
Comment 3
2013-08-03 01:28:07 PDT
Comment on
attachment 208058
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=208058&action=review
> LayoutTests/fast/hidpi/image-srcset-preload-expected.txt:1 > +WARN: shouldBe() expects string arguments
(Just passing by) Looks like an unexpected use of shouldBe below. You should pass the argument as a string and shouldBeFalse will eval it.
Dean Jackson
Comment 4
2013-08-03 04:00:27 PDT
This is a duplicate of
Bug 119360
which has a similar patch (that I'm currently reworking). I'll merge the two patches. *** This bug has been marked as a duplicate of
bug 119360
***
Yoav Weiss
Comment 5
2013-08-03 04:02:25 PDT
Created
attachment 208061
[details]
Patch
Dean Jackson
Comment 6
2013-08-03 04:05:26 PDT
Comment on
attachment 208058
[details]
Patch Merging with the existing patch and review from 119360. It's very similar.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug