Bug 119460 - Remove no-arguments constructor to PropertySlot
Summary: Remove no-arguments constructor to PropertySlot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-02 14:07 PDT by Gavin Barraclough
Modified: 2013-08-02 16:42 PDT (History)
3 users (show)

See Also:


Attachments
fix (30.64 KB, patch)
2013-08-02 14:09 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-08-02 14:07:42 PDT
This is unsafe if getValue is subsequently called, and the property is a getter.  Simplest to just remove it.
Comment 1 Gavin Barraclough 2013-08-02 14:09:43 PDT
Created attachment 208045 [details]
fix
Comment 2 Geoffrey Garen 2013-08-02 14:12:51 PDT
Comment on attachment 208045 [details]
fix

r=me
Comment 3 Gavin Barraclough 2013-08-02 15:31:20 PDT
Fixed in r153673
Comment 4 Benjamin Poulain 2013-08-02 16:42:15 PDT
Most ports are failing to build after this change.