Bug 119457 - The LayoutMilestones didLayout callback should only fire for the main frame
Summary: The LayoutMilestones didLayout callback should only fire for the main frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-02 13:39 PDT by Beth Dakin
Modified: 2013-08-12 14:37 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2013-08-02 13:42 PDT, Beth Dakin
no flags Details | Formatted Diff | Diff
Patch (13.33 KB, patch)
2013-08-06 16:42 PDT, Beth Dakin
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (13.35 KB, patch)
2013-08-06 17:00 PDT, Beth Dakin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-08-02 13:39:00 PDT
The LayoutMilestones didLayout callback should only fire for the main frame since it is a WebView/WebCore::Page-level concept.
Comment 1 Beth Dakin 2013-08-02 13:42:06 PDT
Created attachment 208042 [details]
Patch
Comment 2 Beth Dakin 2013-08-02 14:51:32 PDT
Comment on attachment 208042 [details]
Patch

Sam and I talked about this, and we want to take a slightly different approach here.
Comment 3 Beth Dakin 2013-08-06 16:42:28 PDT
Created attachment 208225 [details]
Patch
Comment 4 Early Warning System Bot 2013-08-06 16:54:55 PDT
Comment on attachment 208225 [details]
Patch

Attachment 208225 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1418015
Comment 5 Early Warning System Bot 2013-08-06 16:58:20 PDT
Comment on attachment 208225 [details]
Patch

Attachment 208225 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1414060
Comment 6 Beth Dakin 2013-08-06 17:00:12 PDT
Created attachment 208228 [details]
Patch
Comment 7 Sam Weinig 2013-08-12 14:19:20 PDT
Comment on attachment 208228 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208228&action=review

> Source/WebCore/loader/FrameLoader.cpp:2286
> +#ifndef NDEBUG

You should use !ASSERT_DISABLED here instead.
Comment 8 Beth Dakin 2013-08-12 14:37:44 PDT
Thanks Sam! http://trac.webkit.org/changeset/153958