Bug 119447 - REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath
Summary: REGRESSION(FTL): Fix mips implementation of ctiVMThrowTrampolineSlowpath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 108664
  Show dependency treegraph
 
Reported: 2013-08-02 09:29 PDT by Julien Brianceau
Modified: 2013-08-16 04:15 PDT (History)
7 users (show)

See Also:


Attachments
ctiVMThrowTrampolineSlowpath fix for mips architecture. (2.16 KB, patch)
2013-08-02 09:36 PDT, Julien Brianceau
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-08-02 09:29:47 PDT
Crashes are observed during javascriptcore tests. For instance, array-defineOwnProperty.js:

This test checks the behavior of [[DefineOwnProperty]] applied to Array objects (see ES5.1 15.4.5.1).

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS Object.defineProperty([], 'x', { get:function(){return true;} }).x is true
PASS Object.defineProperty([], 'length', { value: 1 }).length is 1
PASS var a = Object.defineProperty([], 'length', { writable: false }); a[1] = 1; a.length is 0
PASS var a = Object.defineProperty([], 'length', { writable: false }); a.length = 1; a.length is 0
PASS var a = Object.defineProperty([], 'length', {}); a.length = 1; a.length is 1
Segmentation fault
Comment 1 Julien Brianceau 2013-08-02 09:36:19 PDT
Created attachment 208028 [details]
ctiVMThrowTrampolineSlowpath fix for mips architecture.

This patches fixes the issue on my Broadcom 7241 board.
Comment 2 Geoffrey Garen 2013-08-02 11:21:29 PDT
Comment on attachment 208028 [details]
ctiVMThrowTrampolineSlowpath fix for mips architecture.

r=me
Comment 3 WebKit Commit Bot 2013-08-02 11:44:11 PDT
Comment on attachment 208028 [details]
ctiVMThrowTrampolineSlowpath fix for mips architecture.

Clearing flags on attachment: 208028

Committed r153659: <http://trac.webkit.org/changeset/153659>
Comment 4 WebKit Commit Bot 2013-08-02 11:44:13 PDT
All reviewed patches have been landed.  Closing bug.