Bug 119432 - Remove redundant call of argsList->current() from loops in CSSParser
Summary: Remove redundant call of argsList->current() from loops in CSSParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Byungwoo Lee
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-08-01 23:39 PDT by Byungwoo Lee
Modified: 2013-08-02 03:47 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.61 KB, patch)
2013-08-01 23:47 PDT, Byungwoo Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Byungwoo Lee 2013-08-01 23:39:37 PDT
while loops in CSSParser call argList->current() function at the start
of each iteration, but this is redundant because argsList->next() at
the end of the iteration calls the argList->current() and returns the
result.
Comment 1 Byungwoo Lee 2013-08-01 23:40:35 PDT
blink merge from : https://src.chromium.org/viewvc/blink?view=rev&revision=155402
Comment 2 Byungwoo Lee 2013-08-01 23:47:33 PDT
Created attachment 207986 [details]
Patch
Comment 3 Chris Dumez 2013-08-02 00:01:57 PDT
Comment on attachment 207986 [details]
Patch

Ok, r=me.
Comment 4 WebKit Commit Bot 2013-08-02 03:47:50 PDT
Comment on attachment 207986 [details]
Patch

Clearing flags on attachment: 207986

Committed r153643: <http://trac.webkit.org/changeset/153643>
Comment 5 WebKit Commit Bot 2013-08-02 03:47:53 PDT
All reviewed patches have been landed.  Closing bug.