Bug 11943 – Quirksmode: Break Tag Extra Space Bug

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[David Kilzer (:ddkilzer)]

A break tag in your code when text is aligned right causes a space at the end of the line. This has the effect that the last line in a group appears too far right.

Reported on 5 October 2006.

Test page: http://www.designdetector.com/bugs/break-tag-extra-space-bug.html

Tested on locally-built debug build of WebKit r18399 with Safari 2.0.4 (419.3)
on Mac OS X 10.4.8 (8N1037).

[David Kilzer (:ddkilzer)]

Created attachment 11981 [details]
Test page

[Robert Blaut]

Confirmed in the latest Webkit r30123

[David Kilzer (:ddkilzer)]

No change in behavior with (tested with WebKit nightly build r31893):
<http://trac.webkit.org/projects/webkit/changeset/31734>

[Robert Hogan]

Created attachment 207473 [details]
Patch

[Build Bot]

Comment on attachment 207473 [details]
Patch

Attachment 207473 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1243608

New failing tests:
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html
editing/selection/leak-document-with-selection-inside.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html

[Build Bot]

Created attachment 207592 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Dave Hyatt]

Comment on attachment 207473 [details]
Patch

r=me, but we know that what we really want to do is strip this trailing space out always. Let's file a follow-up bug to do just that and let's put FIXMEs in the code that indicate the right-alignment hack is temporary.

[Robert Hogan]

Created attachment 211927 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 211927 [details]
Patch

Rejecting attachment 211927 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 211927, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1825105

[Robert Hogan]

Created attachment 211947 [details]
Patch

[Antti Koivisto]

So much FIXME and commentary.

[WebKit Commit Bot]

Comment on attachment 211947 [details]
Patch

Clearing flags on attachment: 211947

Committed r156053: <http://trac.webkit.org/changeset/156053>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.