Bug 11943 - Quirksmode: Break Tag Extra Space Bug
: Quirksmode: Break Tag Extra Space Bug
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering
: 420+
: Macintosh Mac OS X 10.4
: P2 Normal
Assigned To: Robert Hogan
http://www.quirksmode.org/bugreports/...
: HasReduction
Depends on:
Blocks: 9610
  Show dependency treegraph
 
Reported: 2006-12-23 04:40 PST by David Kilzer (:ddkilzer)
Modified: 2013-09-18 10:57 PDT (History)
11 users (show)

See Also:


Attachments
Test page (1.92 KB, text/html)
2006-12-23 04:42 PST, David Kilzer (:ddkilzer)
no flags Details
Patch (5.70 KB, patch)
2013-07-25 11:55 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (723.66 KB, application/zip)
2013-07-27 16:56 PDT, Build Bot
no flags Details
Patch (6.01 KB, patch)
2013-09-17 11:20 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff
Patch (6.03 KB, patch)
2013-09-17 14:46 PDT, Robert Hogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2006-12-23 04:40:00 PST
A break tag in your code when text is aligned right causes a space at the end of the line. This has the effect that the last line in a group appears too far right.

Reported on 5 October 2006.

Test page: http://www.designdetector.com/bugs/break-tag-extra-space-bug.html

Tested on locally-built debug build of WebKit r18399 with Safari 2.0.4 (419.3)
on Mac OS X 10.4.8 (8N1037).
Comment 1 David Kilzer (:ddkilzer) 2006-12-23 04:42:00 PST
Created attachment 11981 [details]
Test page
Comment 2 Robert Blaut 2008-02-10 14:44:25 PST
Confirmed in the latest Webkit r30123
Comment 3 David Kilzer (:ddkilzer) 2008-04-14 22:45:15 PDT
No change in behavior with (tested with WebKit nightly build r31893):
<http://trac.webkit.org/projects/webkit/changeset/31734>

Comment 4 Robert Hogan 2013-07-25 11:55:49 PDT
Created attachment 207473 [details]
Patch
Comment 5 Build Bot 2013-07-27 16:56:08 PDT
Comment on attachment 207473 [details]
Patch

Attachment 207473 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1243608

New failing tests:
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html
editing/selection/leak-document-with-selection-inside.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html
csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html
Comment 6 Build Bot 2013-07-27 16:56:10 PDT
Created attachment 207592 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 7 Dave Hyatt 2013-09-04 13:00:12 PDT
Comment on attachment 207473 [details]
Patch

r=me, but we know that what we really want to do is strip this trailing space out always. Let's file a follow-up bug to do just that and let's put FIXMEs in the code that indicate the right-alignment hack is temporary.
Comment 8 Robert Hogan 2013-09-17 11:20:34 PDT
Created attachment 211927 [details]
Patch
Comment 9 WebKit Commit Bot 2013-09-17 14:21:59 PDT
Comment on attachment 211927 [details]
Patch

Rejecting attachment 211927 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 211927, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/1825105
Comment 10 Robert Hogan 2013-09-17 14:46:46 PDT
Created attachment 211947 [details]
Patch
Comment 11 Antti Koivisto 2013-09-18 10:24:08 PDT
So much FIXME and commentary.
Comment 12 WebKit Commit Bot 2013-09-18 10:57:22 PDT
Comment on attachment 211947 [details]
Patch

Clearing flags on attachment: 211947

Committed r156053: <http://trac.webkit.org/changeset/156053>
Comment 13 WebKit Commit Bot 2013-09-18 10:57:25 PDT
All reviewed patches have been landed.  Closing bug.