hasIndexingHeader should be a property of the Structure, not just the IndexingType

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 207974 [details]
the patch

[Mark Hahnenberg]

Comment on attachment 207974 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207974&action=review

> Source/JavaScriptCore/runtime/Structure.h:233
> +        return hasIndexedProperties(indexingType());

Perhaps hasIndexedProperties() should be moved into Structure as well for the sake of consistency?

[Filip Pizlo]

(In reply to comment #2)
> (From update of attachment 207974 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207974&action=review
> 
> > Source/JavaScriptCore/runtime/Structure.h:233
> > +        return hasIndexedProperties(indexingType());
> 
> Perhaps hasIndexedProperties() should be moved into Structure as well for the sake of consistency?

We sometimes call that one without having a Structure*, as you would sort of expect: the point is that the indexing type always entirely determines whether or not you have indexed properties, in the pure-JS-object sense (rather than the typed-array or string sense).

[EFL EWS Bot]

Comment on attachment 207974 [details]
the patch

Attachment 207974 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1330019

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/153657