Bug 119418 - [CSS] Introduce new structure to pass image orientation values.
Summary: [CSS] Introduce new structure to pass image orientation values.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 92330
  Show dependency tree / graph
 
Reported: 2013-08-01 17:41 PDT by Gyuyoung Kim
Modified: 2013-08-14 21:45 PDT (History)
4 users (show)

See Also:

Attachments
WIP (44.88 KB, patch)
2013-08-04 09:13 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for ews (44.93 KB, patch)
2013-08-08 00:25 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for ews (45.87 KB, patch)
2013-08-08 03:36 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (45.85 KB, patch)
2013-08-11 18:30 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Rebased Patch (45.98 KB, patch)
2013-08-13 22:41 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-08-01 17:41:33 PDT 
As commented on https://bugs.webkit.org/show_bug.cgi?id=92330#c6, we need to consider to use new structure in order to reduce argument count. Patch is coming.
Comment 1 Gyuyoung Kim 2013-08-04 09:13:50 PDT 
Created attachment 208093 [details]
WIP
Comment 2 Gyuyoung Kim 2013-08-04 16:32:05 PDT 
Beth, how do you think approach of this patch ?
Comment 3 Beth Dakin 2013-08-05 12:47:37 PDT 
I think this is a good approach!
Comment 4 Gyuyoung Kim 2013-08-08 00:25:53 PDT 
Created attachment 208315 [details]
Patch for ews
Comment 5 Gyuyoung Kim 2013-08-08 00:27:09 PDT 
(In reply to comment #3)
> I think this is a good approach!

Ok, let's go ahead. But, now I'm in Summer vacation. So, my update may be late by end of this week.
Comment 6 Build Bot 2013-08-08 00:58:25 PDT 
Comment on attachment 208315 [details]
Patch for ews

Attachment 208315 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1389231
Comment 7 Build Bot 2013-08-08 01:18:04 PDT 
Comment on attachment 208315 [details]
Patch for ews

Attachment 208315 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1433085
Comment 8 Gyuyoung Kim 2013-08-08 03:36:15 PDT 
Created attachment 208323 [details]
Patch for ews
Comment 9 Gyuyoung Kim 2013-08-11 18:30:11 PDT 
Created attachment 208506 [details]
Patch
Comment 10 Gyuyoung Kim 2013-08-11 18:31:03 PDT 
Beth, could you review this patch ?
Comment 11 Gyuyoung Kim 2013-08-13 22:41:00 PDT 
Created attachment 208699 [details]
Rebased Patch
Comment 12 WebKit Commit Bot 2013-08-14 21:45:24 PDT 
Comment on attachment 208699 [details]
Rebased Patch

Clearing flags on attachment: 208699

Committed r154088: <http://trac.webkit.org/changeset/154088>
Comment 13 WebKit Commit Bot 2013-08-14 21:45:28 PDT 
All reviewed patches have been landed.  Closing bug.