Bug 119412 - Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
Summary: Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-01 15:04 PDT by Simon Fraser (smfr)
Modified: 2013-08-01 15:26 PDT (History)
3 users (show)

See Also:


Attachments
Leaks (181.96 KB, text/plain)
2013-08-01 15:05 PDT, Simon Fraser (smfr)
no flags Details
Patch (2.42 KB, patch)
2013-08-01 15:17 PDT, Anders Carlsson
simon.fraser: review+
Details | Formatted Diff | Diff
My patch (2.22 KB, patch)
2013-08-01 15:18 PDT, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-08-01 15:04:48 PDT
I ran
run-webkit-tests --debug --leaks -2 LayoutTests/compositing/
and got lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
Comment 1 Simon Fraser (smfr) 2013-08-01 15:05:07 PDT
Created attachment 207958 [details]
Leaks
Comment 2 Mark Rowe (bdash) 2013-08-01 15:15:57 PDT
Oh hey, I totally have a patch sitting in my tree that fixes this!
Comment 3 Anders Carlsson 2013-08-01 15:17:06 PDT
Created attachment 207961 [details]
Patch
Comment 4 Mark Rowe (bdash) 2013-08-01 15:18:17 PDT
Created attachment 207962 [details]
My patch

This one fixes the bogus lifetime of the array we pass to the callback.
Comment 5 Mark Rowe (bdash) 2013-08-01 15:23:06 PDT
Anders pointed out that the callback in question has already shipped as part of a Safari release on OS X so we can't just retroactively change the ownership semantics without backwards-compatiblity concerns. We'd need to only change it for new clients, perhaps by bumping the version of the client callback structure.
Comment 6 Anders Carlsson 2013-08-01 15:26:12 PDT
Committed r153616: <http://trac.webkit.org/changeset/153616>