Bug 119411 - Remove pageOverlayShouldApplyFadeWhenPainting() and adopt composited fade for the Mac port
Summary: Remove pageOverlayShouldApplyFadeWhenPainting() and adopt composited fade for...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-01 14:59 PDT by Tim Horton
Modified: 2013-08-03 17:31 PDT (History)
8 users (show)

See Also:

Attachments
patch (11.87 KB, patch)
2013-08-01 15:09 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (15.39 KB, patch)
2013-08-01 23:26 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-01 14:59:31 PDT 
Mac is the only holdout that performs non-composited fades of page overlays. We should adopt that mechanism (as a precursor to doing a CA-accelerated fade) and remove the now-unnecessary property.
Comment 1 Tim Horton 2013-08-01 15:09:38 PDT 
Created attachment 207960 [details]
patch
Comment 2 Tim Horton 2013-08-01 23:26:47 PDT 
Created attachment 207985 [details]
patch

We also need to make WKBundlePageOverlayFractionFadedIn return 1 always, to prevent clients from attempting to bake the fade opacity in.

And, make the find-in-page overlay not bake the opacity in as well.

In doing this I also removed PageOverlay::fractionFadedIn so nobody tries to use it for anything (since it is not useful with composited fade, and will be totally wrong with CA-accelerated fade).
Comment 3 Tim Horton 2013-08-03 17:31:38 PDT 
http://trac.webkit.org/changeset/153692