RESOLVED FIXED119411
Remove pageOverlayShouldApplyFadeWhenPainting() and adopt composited fade for the Mac port 
https://bugs.webkit.org/show_bug.cgi?id=119411
Summary Remove pageOverlayShouldApplyFadeWhenPainting() and adopt composited fade for...
Tim Horton
Reported 2013-08-01 14:59:31 PDT
Mac is the only holdout that performs non-composited fades of page overlays. We should adopt that mechanism (as a precursor to doing a CA-accelerated fade) and remove the now-unnecessary property.
Attachments
patch (11.87 KB, patch)
2013-08-01 15:09 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (15.39 KB, patch)
2013-08-01 23:26 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-08-01 15:09:38 PDT
Created attachment 207960 [details] patch
Tim Horton
Comment 2 2013-08-01 23:26:47 PDT
Created attachment 207985 [details] patch We also need to make WKBundlePageOverlayFractionFadedIn return 1 always, to prevent clients from attempting to bake the fade opacity in. And, make the find-in-page overlay not bake the opacity in as well. In doing this I also removed PageOverlay::fractionFadedIn so nobody tries to use it for anything (since it is not useful with composited fade, and will be totally wrong with CA-accelerated fade).
Tim Horton
Comment 3 2013-08-03 17:31:38 PDT
http://trac.webkit.org/changeset/153692
Note You need to log in before you can comment on or make changes to this bug.