Bug 119409 - DFG optimizations don't handle neutered arrays properly
Summary: DFG optimizations don't handle neutered arrays properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-01 13:55 PDT by Filip Pizlo
Modified: 2013-08-01 15:13 PDT (History)
14 users (show)

See Also:


Attachments
the patch (8.65 KB, patch)
2013-08-01 13:58 PDT, Filip Pizlo
mhahnenberg: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (571.12 KB, application/zip)
2013-08-01 15:06 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-08-01 13:55:54 PDT
Patch forthcoming.

<rdar://problem/14615180>
Comment 1 Filip Pizlo 2013-08-01 13:58:19 PDT
Created attachment 207950 [details]
the patch
Comment 2 Mark Hahnenberg 2013-08-01 14:04:12 PDT
Comment on attachment 207950 [details]
the patch

r=me
Comment 3 Oliver Hunt 2013-08-01 14:04:36 PDT
Comment on attachment 207950 [details]
the patch

r=me.  Typed arrays are so terrible.
Comment 4 EFL EWS Bot 2013-08-01 14:14:43 PDT
Comment on attachment 207950 [details]
the patch

Attachment 207950 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1318136
Comment 5 Build Bot 2013-08-01 15:06:49 PDT
Comment on attachment 207950 [details]
the patch

Attachment 207950 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1309228

New failing tests:
fast/js/dfg-typed-array-neuter.html
fast/canvas/webgl/typed-arrays-in-workers.html
webgl/conformance/typedarrays/typed-arrays-in-workers.html
Comment 6 Build Bot 2013-08-01 15:06:53 PDT
Created attachment 207959 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 7 Filip Pizlo 2013-08-01 15:13:29 PDT
Landed with some additional fixes in http://trac.webkit.org/changeset/153613