Bug 119402 - [cmake] Extra compiler flags should be passed for all target
Summary: [cmake] Extra compiler flags should be passed for all target
Status: RESOLVED DUPLICATE of bug 120812
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 119266
  Show dependency treegraph
 
Reported: 2013-08-01 10:47 PDT by Csaba Osztrogonác
Modified: 2013-09-10 09:23 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-08-01 10:47:53 PDT
It seems extra compiler flags isn't passed for all target now.
I found it when I tried to add back c++11 features and EFL build
failed - https://bugs.webkit.org/show_bug.cgi?id=119266

I'm going to collect which targets are still missing and try to fix.
Comment 1 Csaba Osztrogonác 2013-08-02 07:45:06 PDT
I checked the full EFL build.log and found that "-std=gnu++0x"
isn't passed to the following targets:
- Tools/DumpRenderTree/TestNetscapePlugin
- Tools/DumpRenderTree/efl
- Tools/ImageDiff
- Tools/TestWebKitAPI
- Source/cmake/gtest
- Source/JavaScriptCore/llint/LLIntOffsetExtractor.cpp
- Source/JavaScriptCore/shell (jsc.cpp)
- Source/WebKit/efl/tests
- Source/WebKit2/UIProcess/API/efl/tests
- Source/WebKit2/UIProcess/API/efl/tests
Comment 2 Csaba Osztrogonác 2013-09-10 09:23:37 PDT
Fixed by http://trac.webkit.org/changeset/155163

*** This bug has been marked as a duplicate of bug 120812 ***