Bug 119394 - Frame flattening: Change the logic on whether resize event needs to be dispatched.
Summary: Frame flattening: Change the logic on whether resize event needs to be dispat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Enhancement
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-01 05:49 PDT by zalan
Modified: 2013-08-02 01:57 PDT (History)
7 users (show)

See Also:


Attachments
Patch (10.84 KB, patch)
2013-08-01 06:03 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch for landing (8.30 KB, patch)
2013-08-02 01:02 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch for landing (10.82 KB, patch)
2013-08-02 01:08 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2013-08-01 05:49:45 PDT
Remove the recently added m_resizeEventAllowed and simply go with frameFlatteningEnabled() check.
Comment 1 zalan 2013-08-01 06:03:05 PDT
Created attachment 207920 [details]
Patch
Comment 2 Simon Fraser (smfr) 2013-08-01 08:46:39 PDT
Comment on attachment 207920 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207920&action=review

> Source/WebCore/page/FrameView.h:539
> +    bool supportsFrameFlattening() const;

It's not clear what this means; does it apply only to this frame, or to this platform?
Comment 3 zalan 2013-08-01 08:49:54 PDT
(In reply to comment #2)
> (From update of attachment 207920 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207920&action=review
> 
> > Source/WebCore/page/FrameView.h:539
> > +    bool supportsFrameFlattening() const;
> 
> It's not clear what this means; does it apply only to this frame, or to this platform?

Indeed. I'll fix that before landing. Thanks!
Comment 4 zalan 2013-08-02 01:02:56 PDT
Created attachment 207990 [details]
Patch for landing
Comment 5 zalan 2013-08-02 01:04:11 PDT
Comment on attachment 207990 [details]
Patch for landing

missing testcase
Comment 6 zalan 2013-08-02 01:08:42 PDT
Created attachment 207991 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2013-08-02 01:57:12 PDT
Comment on attachment 207991 [details]
Patch for landing

Clearing flags on attachment: 207991

Committed r153640: <http://trac.webkit.org/changeset/153640>
Comment 8 WebKit Commit Bot 2013-08-02 01:57:16 PDT
All reviewed patches have been landed.  Closing bug.