Bug 119389 – Make WebHistory more type safe

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Patrick R. Gansterer]

Make WebHistory more type safe

[Patrick R. Gansterer]

Created attachment 207912 [details]
Patch

[WebKit Commit Bot]

Attachment 207912 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebHistory.cpp', u'Source/WebKit/win/WebHistory.h']" exit_code: 1
Source/WebKit/win/WebHistory.cpp:532:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/WebHistory.cpp:533:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 207912 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207912&action=review

Looks good!  Can you please use 'auto'?

> Source/WebKit/win/WebHistory.cpp:246
> +    for (URLToEntriesMap::const_iterator it = m_entriesByURL.begin(); it != m_entriesByURL.end(); ++it)

Can this be for (auto it = ...)?

> Source/WebKit/win/WebHistory.cpp:345
> +    for (URLToEntriesMap::const_iterator it = m_entriesByURL.begin(); it != m_entriesByURL.end(); ++i, ++it) {

auto!

>> Source/WebKit/win/WebHistory.cpp:532
>> +    /* [in] */ BSTR url,
> 
> Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]

I've been changing these to be one-line in "WebKit Style" when I'm changing the signature.  Do we really need the STDMETHODCALLTYPE here? I thought that if it was in the header file that was sufficient.

> Source/WebKit/win/WebHistory.cpp:539
> +    URLToEntriesMap::iterator it = m_entriesByURL.find(url);

auto it = ...

> Source/WebKit/win/WebHistory.cpp:549
> +    URLToEntriesMap::iterator it = m_entriesByURL.find(urlString);

auto ...

> Source/WebKit/win/WebHistory.cpp:757
> +    for (URLToEntriesMap::const_iterator it = m_entriesByURL.begin(); it != m_entriesByURL.end(); ++it) {

auto...

[Patrick R. Gansterer]

Created attachment 211733 [details]
Patch

[Brent Fulgham]

Comment on attachment 211733 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 211733 [details]
Patch

Clearing flags on attachment: 211733

Committed r156051: <http://trac.webkit.org/changeset/156051>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.