Bug 119387 - Remove dependency on CoreFoundation from WebIconDatabase
Summary: Remove dependency on CoreFoundation from WebIconDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-01 02:43 PDT by Patrick R. Gansterer
Modified: 2013-09-15 18:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2013-08-01 02:45 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-08-01 02:43:25 PDT 
Remove dependency on CoreFoundation from WebIconDatabase
Comment 1 Patrick R. Gansterer 2013-08-01 02:45:16 PDT 
Created attachment 207910 [details]
Patch
Comment 2 Brent Fulgham 2013-09-15 17:12:09 PDT 
Comment on attachment 207910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207910&action=review

Looks fine, but I'd like to try using DEFINE_STATIC_LOCAL instead of the static initializer.

> Source/WebKit/win/WebIconDatabase.cpp:369
> +    static BSTR iconUserInfoURLKey = SysAllocString(WebIconNotificationUserInfoURLKey);

Can you change this to be DEFINE_STATIC_LOCAL? We are trying to get rid of these static initializers where possible.
Comment 3 Patrick R. Gansterer 2013-09-15 17:35:47 PDT 
Comment on attachment 207910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207910&action=review

>> Source/WebKit/win/WebIconDatabase.cpp:369
>> +    static BSTR iconUserInfoURLKey = SysAllocString(WebIconNotificationUserInfoURLKey);
> 
> Can you change this to be DEFINE_STATIC_LOCAL? We are trying to get rid of these static initializers where possible.

it's now the same as the other functions returning such "key strings"
Comment 4 WebKit Commit Bot 2013-09-15 18:00:07 PDT 
Comment on attachment 207910 [details]
Patch

Clearing flags on attachment: 207910

Committed r155830: <http://trac.webkit.org/changeset/155830>
Comment 5 WebKit Commit Bot 2013-09-15 18:00:08 PDT 
All reviewed patches have been landed.  Closing bug.