RESOLVED FIXED 119387
Remove dependency on CoreFoundation from WebIconDatabase 
https://bugs.webkit.org/show_bug.cgi?id=119387
Summary Remove dependency on CoreFoundation from WebIconDatabase
Patrick R. Gansterer
Reported 2013-08-01 02:43:25 PDT
Remove dependency on CoreFoundation from WebIconDatabase
Attachments
Patch (5.58 KB, patch)
2013-08-01 02:45 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-08-01 02:45:16 PDT
Created attachment 207910 [details] Patch
Brent Fulgham
Comment 2 2013-09-15 17:12:09 PDT
Comment on attachment 207910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207910&action=review Looks fine, but I'd like to try using DEFINE_STATIC_LOCAL instead of the static initializer. > Source/WebKit/win/WebIconDatabase.cpp:369 > + static BSTR iconUserInfoURLKey = SysAllocString(WebIconNotificationUserInfoURLKey); Can you change this to be DEFINE_STATIC_LOCAL? We are trying to get rid of these static initializers where possible.
Patrick R. Gansterer
Comment 3 2013-09-15 17:35:47 PDT
Comment on attachment 207910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207910&action=review >> Source/WebKit/win/WebIconDatabase.cpp:369 >> + static BSTR iconUserInfoURLKey = SysAllocString(WebIconNotificationUserInfoURLKey); > > Can you change this to be DEFINE_STATIC_LOCAL? We are trying to get rid of these static initializers where possible. it's now the same as the other functions returning such "key strings"
WebKit Commit Bot
Comment 4 2013-09-15 18:00:07 PDT
Comment on attachment 207910 [details] Patch Clearing flags on attachment: 207910 Committed r155830: <http://trac.webkit.org/changeset/155830>
WebKit Commit Bot
Comment 5 2013-09-15 18:00:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.