Bug 119379 - Remove return statement in void function
Summary: Remove return statement in void function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-31 23:57 PDT by Kwang Yul Seo
Modified: 2013-08-01 14:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.77 KB, patch)
2013-08-01 00:38 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (1.82 KB, patch)
2013-08-01 00:45 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2013-07-31 23:57:37 PDT
It does not make sense to return a value in void function.
Comment 1 Kwang Yul Seo 2013-08-01 00:38:36 PDT
Created attachment 207902 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-01 00:40:51 PDT
Attachment 207902 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebKit2/WebProcess/WebProcess.cpp:815:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:816:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-08-01 00:42:59 PDT
Comment on attachment 207902 [details]
Patch

This patch is incorrect.
If the string is 8-bit, you will now execute the second addCharacters call as well.
Comment 4 Kwang Yul Seo 2013-08-01 00:45:45 PDT
Created attachment 207903 [details]
Patch
Comment 5 Kwang Yul Seo 2013-08-01 00:47:01 PDT
(In reply to comment #3)
> (From update of attachment 207902 [details])
> This patch is incorrect.
> If the string is 8-bit, you will now execute the second addCharacters call as well.

Thanks for the quick review. I noticed it too and uploaded a new patch.
Comment 6 WebKit Commit Bot 2013-08-01 00:47:55 PDT
Attachment 207903 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebKit2/WebProcess/WebProcess.cpp:815:  Missing spaces around >>  [whitespace/operators] [3]
Source/WebKit2/WebProcess/WebProcess.cpp:818:  Missing spaces around >>  [whitespace/operators] [3]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Kwang Yul Seo 2013-08-01 00:51:33 PDT
(In reply to comment #6)
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
> Source/WebKit2/WebProcess/WebProcess.cpp:815:  Missing spaces around >>  [whitespace/operators] [3]
> Source/WebKit2/WebProcess/WebProcess.cpp:818:  Missing spaces around >>  [whitespace/operators] [3]
> Total errors found: 2 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

BTW, check-webkit-style does not recognize a template within a template (no space between ending >>). We should file a bug to fix this because now we compile everything in C++11 mode.
Comment 8 Kwang Yul Seo 2013-08-01 14:49:46 PDT
Comment on attachment 207903 [details]
Patch

Clearing flags on attachment: 207903

Committed r153611: <http://trac.webkit.org/changeset/153611>
Comment 9 Kwang Yul Seo 2013-08-01 14:49:50 PDT
All reviewed patches have been landed.  Closing bug.