Bug 119377 - Reloading this video test shows garbage briefly
Summary: Reloading this video test shows garbage briefly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://trac.webkit.org/export/153570/...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-31 23:08 PDT by Simon Fraser (smfr)
Modified: 2013-08-22 11:47 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2013-08-21 17:59 PDT, Simon Fraser (smfr) 		andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (528.76 KB, application/zip)
2013-08-22 03:54 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-07-31 23:08:46 PDT 
Reloading http://trac.webkit.org/export/153570/trunk/LayoutTests/compositing/overflow/overflow-compositing-descendant.html on mountain lion shows a flash of garbage pixels where the video should be.
Comment 1 Simon Fraser (smfr) 2013-08-21 17:42:31 PDT 
RenderVideo::foregroundIsKnownToBeOpaqueInRect() lies. It needs to ask the media player if it's actually going to show anything.
Comment 2 Simon Fraser (smfr) 2013-08-21 17:59:28 PDT 
Created attachment 209318 [details]
Patch
Comment 3 Build Bot 2013-08-22 03:54:16 PDT 
Comment on attachment 209318 [details]
Patch

Attachment 209318 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1393100

New failing tests:
fast/workers/termination-with-port-messages.html
Comment 4 Build Bot 2013-08-22 03:54:18 PDT 
Created attachment 209341 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 5 Anders Carlsson 2013-08-22 07:51:59 PDT 
Comment on attachment 209318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209318&action=review

> Source/WebCore/rendering/RenderVideo.cpp:350
> +    MediaPlayer* player = mediaElement()->player();
> +    if (player)

I'd put these on the same line.
Comment 6 Simon Fraser (smfr) 2013-08-22 11:47:44 PDT 
https://trac.webkit.org/r154455