Bug 119365 - [BlackBerry] Page scrolls when width equals device width and initial scale is greater than 0.92
Summary: [BlackBerry] Page scrolls when width equals device width and initial scale is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jacky Jiang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-31 17:53 PDT by Jacky Jiang
Modified: 2013-07-31 19:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2013-07-31 18:22 PDT, Jacky Jiang 		no flags Details | Formatted Diff | Diff
Patch (5.87 KB, patch)
2013-07-31 19:00 PDT, Jacky Jiang 		rwlbuis: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacky Jiang 2013-07-31 17:53:14 PDT 
JIRA 445423.
Comment 1 Jacky Jiang 2013-07-31 18:22:56 PDT 
Created attachment 207891 [details]
Patch
Comment 2 Rob Buis 2013-07-31 18:34:59 PDT 
Comment on attachment 207891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207891&action=review

Looks good in general.

> Source/WebKit/blackberry/Api/WebPage.cpp:1704
> +    float idealContentsHeight = static_cast<float>(this->transformedActualVisibleSize().height()) / devicePixelRatio;

Are you sure this-> is needed here?

> Source/WebKit/blackberry/Api/WebPage.cpp:1708
> +    return false;

You could replace the if with a return, and then you don't need the return false; statement.
Comment 3 Jacky Jiang 2013-07-31 18:41:43 PDT 
Comment on attachment 207891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207891&action=review

>> Source/WebKit/blackberry/Api/WebPage.cpp:1704
>> +    float idealContentsHeight = static_cast<float>(this->transformedActualVisibleSize().height()) / devicePixelRatio;
> 
> Are you sure this-> is needed here?

Oops, it's not needed. Previously I was writing something like "transformedActualVisibleSize = this->transformedActualVisibleSize()" and I forgot to remove "this" when I changed the code. 
I will remove it.

>> Source/WebKit/blackberry/Api/WebPage.cpp:1708
>> +    return false;
> 
> You could replace the if with a return, and then you don't need the return false; statement.

Good idea. Will update.
Comment 4 Jacky Jiang 2013-07-31 19:00:31 PDT 
Created attachment 207894 [details]
Patch
Comment 5 Rob Buis 2013-07-31 19:05:03 PDT 
Comment on attachment 207894 [details]
Patch

Excellent! :)
Comment 6 Jacky Jiang 2013-07-31 19:21:02 PDT 
Committed r153562: <http://trac.webkit.org/changeset/153562>