Bug 119358 - Reuse of XMLHttpRequests causes character corruption in response text
Summary: Reuse of XMLHttpRequests causes character corruption in response text
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Critical
Assignee: Ryosuke Niwa
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Blocks:
 
Reported: 2013-07-31 16:42 PDT by Ryosuke Niwa
Modified: 2013-12-18 19:29 PST (History)
9 users (show)

See Also:


Attachments
Fixes the bug (5.80 KB, patch)
2013-07-31 16:55 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-31 16:42:11 PDT
Merge https://chromiumcodereview.appspot.com/20625004

XMLHttpRequest should clear the response encoding if it clears responseText.

XMLHttpRequest did not clear the response encoding when it have should, for example, when abort() is called.
This caused character corruption in responseText if we re-opened the XHR object.
Comment 1 Radar WebKit Bug Importer 2013-07-31 16:42:45 PDT
<rdar://problem/14612613>
Comment 2 Ryosuke Niwa 2013-07-31 16:55:34 PDT
Created attachment 207887 [details]
Fixes the bug
Comment 3 WebKit Commit Bot 2013-07-31 17:50:25 PDT
Comment on attachment 207887 [details]
Fixes the bug

Clearing flags on attachment: 207887

Committed r153553: <http://trac.webkit.org/changeset/153553>
Comment 4 WebKit Commit Bot 2013-07-31 17:50:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 David Kilzer (:ddkilzer) 2013-12-18 19:29:00 PST
(In reply to comment #0)
> Merge https://chromiumcodereview.appspot.com/20625004

Issue 261140:	Reuse of XMLHttpRequests causes character corruption in response text https://code.google.com/p/chromium/issues/detail?id=261140