Bug 119352 - Make ActiveDOMObject overrides private
Summary: Make ActiveDOMObject overrides private
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2013-07-31 14:20 PDT by Alexey Proskuryakov
Modified: 2013-07-31 17:20 PDT (History)
5 users (show)

See Also:

proposed patch (18.95 KB, patch)
2013-07-31 14:22 PDT, Alexey Proskuryakov
sam: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (17.94 KB, patch)
2013-07-31 15:40 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-07-31 14:20:05 PDT
There is no need to call these through derived classes. And it's quite harmful for anyone except for ScriptExecutionContext to call suspend/resume in particular - ScriptExecutionContext won't know, and it will try to manage the state on its own.
Comment 1 Alexey Proskuryakov 2013-07-31 14:22:48 PDT
Created attachment 207876 [details]
proposed patch
Comment 2 EFL EWS Bot 2013-07-31 15:28:39 PDT
Comment on attachment 207876 [details]
proposed patch

Attachment 207876 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1292787
Comment 3 Alexey Proskuryakov 2013-07-31 15:40:24 PDT
Created attachment 207882 [details]
patch for landing

Kept public hasPendingActivity() where generated JS bindings needs it.
Comment 4 WebKit Commit Bot 2013-07-31 17:20:19 PDT
Comment on attachment 207882 [details]
patch for landing

Clearing flags on attachment: 207882

Committed r153551: <http://trac.webkit.org/changeset/153551>
Comment 5 WebKit Commit Bot 2013-07-31 17:20:21 PDT
All reviewed patches have been landed.  Closing bug.