Bug 119351 - [Windows] Winlauncher shouldn't look for Safari Install Directory
Summary: [Windows] Winlauncher shouldn't look for Safari Install Directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-31 14:17 PDT by Brent Fulgham
Modified: 2013-07-31 16:07 PDT (History)
0 users

See Also:

Attachments
Patch (2.80 KB, patch)
2013-07-31 14:26 PDT, Brent Fulgham 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-07-31 14:17:06 PDT 
The way we distribute the support libraries needed by WinLauncher and other software has changed. Instead of looking for the Safari directory (which may not exist), use the 'Common Files' target location where all support libraries are installed.

This will avoid set-up problems on new systems, and make it easier to setup and deploy build/test bots.
Comment 1 Brent Fulgham 2013-07-31 14:26:31 PDT 
Created attachment 207877 [details]
Patch
Comment 2 Darin Adler 2013-07-31 15:29:38 PDT 
Comment on attachment 207877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207877&action=review

> Tools/win/DLLLauncher/DLLLauncherMain.cpp:124
> +static bool directoryExists(wstring path)

I suggest const wstring& here.
Comment 3 Brent Fulgham 2013-07-31 15:36:07 PDT 
(In reply to comment #2)
> (From update of attachment 207877 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207877&action=review
> 
> > Tools/win/DLLLauncher/DLLLauncherMain.cpp:124
> > +static bool directoryExists(wstring path)
> 
> I suggest const wstring& here.

Ah! Missed that.  Thanks!
Comment 4 Brent Fulgham 2013-07-31 16:07:02 PDT 
Committed r153544: <http://trac.webkit.org/changeset/153544>