Bug 119340 – [GTK] Add pango to jhbuild and raise fontconfig version in order to build GTK+ after r153518

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Simon Pena]

[GTK] Add pango to jhbuild and raise fontconfig version in order to build GTK+ after r153518

[Simon Pena]

Created attachment 207854 [details]
Patch

[Martin Robinson]

Comment on attachment 207854 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207854&action=review

> Tools/gtk/jhbuild.modules:194
> -    <branch module="software/fontconfig/release/fontconfig-2.8.0.tar.gz" version="2.8.0"
> +    <branch module="software/fontconfig/release/fontconfig-2.10.93.tar.gz" version="2.10.93"
>              repo="freedesktop.org"
> -            hash="sha256:fa2a1c6eea654d9fce7a4b1220f10c99cdec848dccaf1625c01f076b31382335"
> -            md5sum="77e15a92006ddc2adbb06f840d591c0e">
> +            hash="sha256:381541e4d1a150dac46af1d9ad64bdc3a131d6b2707d192209b2ed26e3e64147"
> +            md5sum="7772133ecce109f805ad8a2c1cce1dc7">
>      </branch>

Did you run pixel tests after this change?

> Tools/gtk/jhbuild.modules:329
> +  <autotools id="pango"
> +             autogenargs="--disable-introspection">
> +    <dependencies>
> +      <dep package="glib"/>
> +      <dep package="freetype6"/>
> +      <dep package="cairo"/>
> +      <dep package="fontconfig"/>
> +    </dependencies>
> +    <branch module="/pub/GNOME/sources/pango/1.32/pango-1.32.6.tar.xz" version="1.32.6"
> +            repo="ftp.gnome.org"
> +            hash="sha256:8e9a3eadebf30a31640f2b3ae0fb455cf92d10d1cad246d0ffe72ec595905174"
> +            md5sum="1af2e3a0ac5a258eff5ceddb6ed60ebd"/>
> +  </autotools>
> +

This belongs in the optional moduleset now. Pango doesn't change test results.

[Simon Pena]

(In reply to comment #2)
> (From update of attachment 207854 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207854&action=review
> 
> > Tools/gtk/jhbuild.modules:194
> > -    <branch module="software/fontconfig/release/fontconfig-2.8.0.tar.gz" version="2.8.0"
> > +    <branch module="software/fontconfig/release/fontconfig-2.10.93.tar.gz" version="2.10.93"
> >              repo="freedesktop.org"
> > -            hash="sha256:fa2a1c6eea654d9fce7a4b1220f10c99cdec848dccaf1625c01f076b31382335"
> > -            md5sum="77e15a92006ddc2adbb06f840d591c0e">
> > +            hash="sha256:381541e4d1a150dac46af1d9ad64bdc3a131d6b2707d192209b2ed26e3e64147"
> > +            md5sum="7772133ecce109f805ad8a2c1cce1dc7">
> >      </branch>
> 
> Did you run pixel tests after this change?

No, I didn't. I will do that and report the results.
 
> > Tools/gtk/jhbuild.modules:329
> > +  <autotools id="pango"
> > +             autogenargs="--disable-introspection">
> > +    <dependencies>
> > +      <dep package="glib"/>
> > +      <dep package="freetype6"/>
> > +      <dep package="cairo"/>
> > +      <dep package="fontconfig"/>
> > +    </dependencies>
> > +    <branch module="/pub/GNOME/sources/pango/1.32/pango-1.32.6.tar.xz" version="1.32.6"
> > +            repo="ftp.gnome.org"
> > +            hash="sha256:8e9a3eadebf30a31640f2b3ae0fb455cf92d10d1cad246d0ffe72ec595905174"
> > +            md5sum="1af2e3a0ac5a258eff5ceddb6ed60ebd"/>
> > +  </autotools>
> > +
> 
> This belongs in the optional moduleset now. Pango doesn't change test results.

Žan also recommended doing that. However, I wonder if we can have GTK+, in one moduleset, requiring Pango, and then Pango, in a different moduleset, requiring fontconfig, which itself is in the first moduleset. Are these "cross-references" supported?

[Simon Pena]

r153518 has been rolled out, so this patch is no longer needed.