Bug 119336 - [Qt] ASSERTS trigger in release builds
Summary: [Qt] ASSERTS trigger in release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-31 05:03 PDT by Allan Sandfeld Jensen
Modified: 2013-07-31 06:47 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.23 KB, patch)
2013-07-31 05:06 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2013-07-31 05:36 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-07-31 05:03:00 PDT 
Recently I have started hitting asserts when doing debug_and_release or release builds. It appears NDEBUG is not defined.
Comment 1 Allan Sandfeld Jensen 2013-07-31 05:06:13 PDT 
Created attachment 207838 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2013-07-31 05:20:28 PDT 
Comment on attachment 207838 [details]
Patch

I am being told this is wrong, and the old test should still work.
Comment 3 Allan Sandfeld Jensen 2013-07-31 05:32:33 PDT 
It seems the build can end up being neither release nor debug according to qmake.
Comment 4 Allan Sandfeld Jensen 2013-07-31 05:36:20 PDT 
Created attachment 207841 [details]
Patch
Comment 5 Allan Sandfeld Jensen 2013-07-31 05:48:33 PDT 
Comment on attachment 207841 [details]
Patch

Clearing flags on attachment: 207841

Committed r153519: <http://trac.webkit.org/changeset/153519>
Comment 6 Allan Sandfeld Jensen 2013-07-31 05:48:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Tor Arne Vestbø 2013-07-31 06:47:49 PDT 
Comment on attachment 207841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207841&action=review

> Tools/qmake/mkspecs/features/default_post.prf:32
> +        !debug:!release: CONFIG += release

This seems dubious. Why are we missing a config in the first place?