Bug 11933 - REGRESSION: trying to change a property in a computed style declaration results in a crash
Summary: REGRESSION: trying to change a property in a computed style declaration resul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2006-12-22 10:35 PST by Alexey Proskuryakov
Modified: 2006-12-23 23:24 PST (History)
1 user (show)

See Also:

Attachments
proposed fix (5.37 KB, patch)
2006-12-22 11:31 PST, Alexey Proskuryakov 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2006-12-22 10:35:26 PST 
Patch forthcoming.
Comment 1 Alexey Proskuryakov 2006-12-22 11:31:22 PST 
Created attachment 11971 [details]
proposed fix
Comment 2 Geoffrey Garen 2006-12-22 14:40:35 PST 
Comment on attachment 11971 [details]
proposed fix

r=me
Comment 3 Geoffrey Garen 2006-12-22 14:41:28 PST 
That assertion has proven helpful in the past, so it might be useful to assert "has stylesheet or is computedStyleDeclaration." Just a thought.
Comment 4 Alexey Proskuryakov 2006-12-22 22:25:12 PST 
(In reply to comment #3)
> That assertion has proven helpful in the past, so it might be useful to assert
> "has stylesheet or is computedStyleDeclaration." Just a thought.

I also thought so, but couldn't find any way to tell that a style declaration is a computed one. Is there any? Adding a new virtual function for the sake of an assertion seemed a bit too much to me.
Comment 5 Geoffrey Garen 2006-12-22 22:41:22 PST 
Agreed.
Comment 6 Geoffrey Garen 2006-12-22 22:41:42 PST 
I can't see a good way to do what I suggested.
Comment 7 Alexey Proskuryakov 2006-12-23 23:24:59 PST 
Committed revision 18406, although this code will be rewritten soon, because enabling exceptions for invalid CSS turned out to be too dangerous for compatibility.