Bug 119319 - Don't use Vector<UChar> to build strings
Summary: Don't use Vector<UChar> to build strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Blocks:
 
Reported: 2013-07-30 21:38 PDT by Ryosuke Niwa
Modified: 2022-12-19 07:20 PST (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-30 21:38:40 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/9fda929af533c3c1aa3961c4818ea30ed7499021

This CL removes a bunch of code sites that were using Vector<UChar> to
construct strings. That used to be a good way to construct strings, but in the
modern world, we have much better alternatives in the form of StringBuffer and
StringBuilder. (You should use StringBuffer if you know exactly how much memory
you need and you should use StringBuilder if you require a variable amount of
memory.)

This CL removes more clients of the StringImpl pointer. There are still a few
left, which require more study.
Comment 1 Ryosuke Niwa 2022-08-21 19:08:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3518
Comment 2 EWS 2022-12-19 07:19:17 PST 
Committed 258081@main (6b1eb391bf3d): <https://commits.webkit.org/258081@main>

Reviewed commits have been landed. Closing PR #7827 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-12-19 07:20:17 PST 
<rdar://problem/103514934>