Bug 119298 - JSOESTextureHalfFloat not generated on Windows
Summary: JSOESTextureHalfFloat not generated on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 18:14 PDT by Alex Christensen
Modified: 2013-08-01 09:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.65 KB, patch)
2013-07-30 18:19 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-07-30 18:14:03 PDT
I have spent weeks wondering why OESTextureHalfFloat wasn't working on Windows.  JSOESTextureHalfFloat.h and JSOESTextureHalfFloat.cpp were not being generated.  After going through every possible difference between OESTextureHalfFloat and OESTextureFloat I found the problem: OESTextureHalfFloat.idl doesn't end with a newline, which was making generate-bindings.pl fail, but only on Windows.
Comment 1 Alex Christensen 2013-07-30 18:19:00 PDT
Created attachment 207793 [details]
Patch
Comment 2 Chris Dumez 2013-07-30 22:24:41 PDT
Comment on attachment 207793 [details]
Patch

r=me.
Comment 3 WebKit Commit Bot 2013-08-01 09:52:38 PDT
Comment on attachment 207793 [details]
Patch

Clearing flags on attachment: 207793

Committed r153588: <http://trac.webkit.org/changeset/153588>
Comment 4 WebKit Commit Bot 2013-08-01 09:52:40 PDT
All reviewed patches have been landed.  Closing bug.