Bug 119296 – wrong static_casts in ANGLE

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Alex Christensen]

When I updated ANGLE in https://bugs.webkit.org/show_bug.cgi?id=118550 I added static_casts to Intermediate.cpp, but as pointed out in https://code.google.com/p/angleproject/issues/detail?id=450 I did the wrong casts.  This will cause it to return the wrong value in whatever this code does, especially with my cast to bool instead of int.  I suggest this be fixed immediately.

[Alex Christensen]

Created attachment 207789 [details]
Patch

[WebKit Commit Bot]

Attachment 207789 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp', u'Source/ThirdParty/ANGLE/src/compiler/intermediate.h']" exit_code: 1
Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1406:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Created attachment 207790 [details]
Patch

[WebKit Commit Bot]

Attachment 207790 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp', u'Source/ThirdParty/ANGLE/src/compiler/intermediate.h']" exit_code: 1
Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1406:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 207790 [details]
Patch

Clearing flags on attachment: 207790

Committed r153600: <http://trac.webkit.org/changeset/153600>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.