Bug 119289 - Correct the elapsedTime calculation in SVG animations
Summary: Correct the elapsedTime calculation in SVG animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-07-30 16:18 PDT by Ryosuke Niwa
Modified: 2013-10-31 16:21 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.80 KB, patch)
2013-09-13 05:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-07-30 16:18:11 PDT 
Consider merging https://chromium.googlesource.com/chromium/blink/+/338f9badca7fb7880abdb0cecd5f02493c1f7d2e

As per the SVG standard, SVG document on receiving the
pauseAnimations() should also pause the animation clock corresponding
to the SVG document. Whereas current implmentation also takes into
account the accumulated pause time which is not required.
So replacing the m_accumulatedPauseTime with m_accumulatedActiveTime
and other corresponding calculations.
Added the layout Test.
Comment 1 youenn fablet 2013-09-13 05:58:21 PDT 
Created attachment 211547 [details]
Patch
Comment 2 Brent Fulgham 2013-10-31 14:52:45 PDT 
Comment on attachment 211547 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2013-10-31 16:21:23 PDT 
Comment on attachment 211547 [details]
Patch

Clearing flags on attachment: 211547

Committed r158405: <http://trac.webkit.org/changeset/158405>
Comment 4 WebKit Commit Bot 2013-10-31 16:21:25 PDT 
All reviewed patches have been landed.  Closing bug.