Bug 119282 - revalidateTiles and ensureTilesForRect can share a lot of code
Summary: revalidateTiles and ensureTilesForRect can share a lot of code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 15:28 PDT by Tim Horton
Modified: 2013-08-21 14:07 PDT (History)
3 users (show)

See Also:


Attachments
take one (7.21 KB, patch)
2013-07-30 15:29 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
take two (7.46 KB, patch)
2013-08-07 17:26 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
patch (8.96 KB, patch)
2013-08-15 17:53 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-07-30 15:28:56 PDT
They share lots of code, but it's kind of scary to change these.
Comment 1 Tim Horton 2013-07-30 15:29:20 PDT
Created attachment 207774 [details]
take one
Comment 2 Tim Horton 2013-08-07 17:26:09 PDT
Created attachment 208306 [details]
take two

needs a change log but I have to go fix something else, attaching new patch for now
Comment 3 Tim Horton 2013-08-15 17:53:12 PDT
Created attachment 208872 [details]
patch
Comment 4 Simon Fraser (smfr) 2013-08-16 17:32:50 PDT
Comment on attachment 208872 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208872&action=review

> Source/WebCore/platform/graphics/ca/mac/TileController.h:149
> +    enum class NewTileType { PrimaryTiles, SecondaryTiles };

Maybe CoverageType?

> Source/WebCore/platform/graphics/ca/mac/TileController.h:150
> +    IntRect ensureTilesForRect(const FloatRect&, NewTileType);

What does the return value mean?
Comment 5 Tim Horton 2013-08-21 14:04:01 PDT
http://trac.webkit.org/changeset/154413
Comment 6 Tim Horton 2013-08-21 14:07:57 PDT
and http://trac.webkit.org/changeset/154415