Bug 119279 - Speculative fix for crash due to string access on multiple threads
Summary: Speculative fix for crash due to string access on multiple threads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-30 14:46 PDT by Anders Carlsson
Modified: 2013-07-30 21:14 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.79 KB, patch)
2013-07-30 14:53 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-07-30 14:46:28 PDT 
Speculative fix for crash due to string access on multiple threads
Comment 1 Anders Carlsson 2013-07-30 14:53:47 PDT 
Created attachment 207768 [details]
Patch
Comment 2 Anders Carlsson 2013-07-30 15:19:14 PDT 
Committed r153499: <http://trac.webkit.org/changeset/153499>
Comment 3 Darin Adler 2013-07-30 21:14:52 PDT 
Comment on attachment 207768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207768&action=review

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:56
> +    RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.impl() ? localStorageDirectory.impl()->isolatedCopy() : nullptr;

Is this really better than:

    RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.isolatedCopy().impl();

? Wish I had thought of that before you landed it.