It seems code guarded by CSS_SHADER uses Angle, which is not built with --no-webgl.
Created attachment 208298 [details] Patch CSS Shaders requires WebGL. Add error message to dependency failure.
@achicu: CSS Shaders require ANGLE to build, and this is not available if WEBGL if disabled from say build-webkit. Does it make sense to have a hard dependency on each other, as the patch does?
Comment on attachment 208298 [details] Patch please read http://www.webkit.org/coding/contributing.html
Created attachment 208539 [details] Patch
Comment on attachment 208539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review > Source/WTF/ChangeLog:8 > + CSS_SHADERS requires WEBGL enabled. Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on?
Comment on attachment 208539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review >> Source/WTF/ChangeLog:8 >> + CSS_SHADERS requires WEBGL enabled. > > Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? Custom Filters are implemented on top of WebGL. We are only using ANGLE to validate the shaders, so we need both.
Comment on attachment 208539 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208539&action=review >>> Source/WTF/ChangeLog:8 >>> + CSS_SHADERS requires WEBGL enabled. >> >> Is not it more accurate to say that it requeres ANGLE, which is only available when WebGL is on? > > Custom Filters are implemented on top of WebGL. We are only using ANGLE to validate the shaders, so we need both. ok thanks
Comment on attachment 208539 [details] Patch Clearing flags on attachment: 208539 Committed r153951: <http://trac.webkit.org/changeset/153951>
All reviewed patches have been landed. Closing bug.