Bug 119258 – [WebKit2] [Gtk] WebKitResponsePolicyDecision URI response property incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Brian Holt]

g_object_class_install_property(objectClass,
                                    PROP_REQUEST,
                                    g_param_spec_object("response",
                                                      _("URI response"),
                                                      _("The URI response that is associated with this policy decision"),
                                                      WEBKIT_TYPE_URI_REQUEST,
                                                      WEBKIT_PARAM_READABLE));

[Brian Holt]

Created attachment 207736 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Brian Holt]

Comment on attachment 207736 [details]
Patch

Cancelling review: in eclipse I couldn't see the _ that preceded the parentheses.  Apologies.

[Brian Holt]

Created attachment 207737 [details]
Patch

[Brian Holt]

Comment on attachment 207737 [details]
Patch

Thanks for the review! Setting CQ?

[Carlos Garcia Campos]

Comment on attachment 207737 [details]
Patch

What was wrong here? just the coding style?

[Carlos Garcia Campos]

Comment on attachment 207737 [details]
Patch

Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this.

[Brian Holt]

(In reply to comment #7)
> (From update of attachment 207737 [details])
> Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this.

Sorry Carlos, I though my comment in the changeLog "Corrected the installed URI response property" was sufficient but I'll expand on that a bit more.  Its definitely not just a style change :-)

[Brian Holt]

Created attachment 207738 [details]
Updated Patch

[Carlos Garcia Campos]

(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 207737 [details] [details])
> > Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this.
> 
> Sorry Carlos, I though my comment in the changeLog "Corrected the installed URI response property" was sufficient but I'll expand on that a bit more.  Its definitely not just a style change :-)

That says there's something wrong, but not what, it took me a while to find what was wrong. Thanks for updating it.

[Carlos Garcia Campos]

(In reply to comment #9)
> Created an attachment (id=207738) [details]
> Updated Patch

When submitting an updated patch that has already been r+'ed, you can upload the patch with the reviewer line filled, and only ask for commit-queue. Note that I didn't r- the patch, just cq-.

[Brian Holt]

Created attachment 207739 [details]
Updated Patch

[Carlos Garcia Campos]

Comment on attachment 207739 [details]
Updated Patch

Excellent, thanks!

[Martin Robinson]

Thanks for pointing that out Carlos. It took me a moment to find the actual issue. And thanks Brian for fixing it. :)

[WebKit Commit Bot]

Comment on attachment 207739 [details]
Updated Patch

Clearing flags on attachment: 207739

Committed r153479: <http://trac.webkit.org/changeset/153479>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.