WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 119252
Web Inspector: doesn't use localized user interface at remote inspector
https://bugs.webkit.org/show_bug.cgi?id=119252
Summary
Web Inspector: doesn't use localized user interface at remote inspector
Roland Takacs
Reported
2013-07-30 06:22:27 PDT
The normal inspector uses InspectorFrontendHost::localizedStringsURL() to get the path/url of localizedStrings. It is undefined at remote inspector: thats why we need to tell the inspector that we wouldn't like to use localizedStrings.
Attachments
patch
(2.40 KB, patch)
2013-07-30 06:24 PDT
,
Roland Takacs
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-07-30 06:23:03 PDT
<
rdar://problem/14589626
>
Roland Takacs
Comment 2
2013-07-30 06:24:42 PDT
Created
attachment 207730
[details]
patch
WebKit Commit Bot
Comment 3
2013-07-30 06:51:04 PDT
Comment on
attachment 207730
[details]
patch Clearing flags on attachment: 207730 Committed
r153471
: <
http://trac.webkit.org/changeset/153471
>
WebKit Commit Bot
Comment 4
2013-07-30 06:51:06 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 5
2013-07-30 11:00:40 PDT
(In reply to
comment #0
)
> The normal inspector uses InspectorFrontendHost::localizedStringsURL() to get the path/url of localizedStrings. > It is undefined at remote inspector: thats why we need to tell the inspector that we wouldn't like to use localizedStrings.
You should file a follow-up bug to get this working in your case (that is, if you want localization for the remote inspector). Seems like it would be pretty easy to add something like this.
Seokju Kwon
Comment 6
2013-07-30 16:21:33 PDT
Hmm, I wonder that why you don't use it in remote inspector. And Why do you set a default value to true? If you dont use localizedStrings in remote inspector, You should set a value to true when using remote inspector.
Joseph Pecoraro
Comment 7
2013-07-30 16:56:04 PDT
(In reply to
comment #6
)
> Hmm, I wonder that why you don't use it in remote inspector. > > And Why do you set a default value to true? > If you dont use localizedStrings in remote inspector, You should set a value to true when using remote inspector.
OS X Remote Inspector does have localization. It uses the WebInspectorUI.framework on the host machine which has all the localizations. We have a real InspectorFrontendHost, we aren't using the stub, so we provide a local file:/// path to the localizedStrings.js when asking InspectorFrontendHost.localizedStringsURL().
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug